[JAV-585]Loadbalance rule dynamic configuration is not work at some time #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
approved these changes
Dec 21, 2017
wujimin
reviewed
Dec 21, 2017
| boolean isRuleNotChanged = StringUtils.equals(policy,this.policy) && StringUtils.equals(strategy, this.strategy); | ||
|
|
||
| if (!isRuleNotChanged){ | ||
| boolean isRuleNotChanged = isEqual(policy, this.policy) && isEqual(strategy,this.strategy); |
There was a problem hiding this comment.
Yeah, I forget it and I have modified
wujimin
reviewed
Dec 21, 2017
| Assert.assertEquals(false, globalNotNull); | ||
| boolean localNotNull = handler.isEqual("com.netflix.loadbalancer.RandomRule", null); | ||
| Assert.assertEquals(false, localNotNull); | ||
|
|
There was a problem hiding this comment.
okay, and I finished
wujimin
approved these changes
Dec 21, 2017
|
@laijianbin I don't think you logged a right JIRA ID. Can you double check the JIRA ID? |
|
@WillemJiang create a task at opensource JIRA and use opensource JIRA ID? |
laijianbin
changed the title
|
Changes Unknown when pulling 662d8c9 on laijianbin:jhfre into ** on apache:master**. |
WillemJiang
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[JAV-XXX] Fixes bug in ApproximateQuantiles, where you replaceJAV-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.