Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-179 support -(java identifiers) as parameter name with RequestParam #491

Closed
wants to merge 2 commits into from

Conversation

acsukesh
Copy link
Contributor

@acsukesh acsukesh commented Jan 5, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 87.422% when pulling 57b238d on acsukesh:master into a4720c6 on apache:master.

Copy link
Contributor

@liubao68 liubao68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide a test case for this modification in integration tests? you can refer #482 for examples.

Copy link
Contributor

@wujimin wujimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better move the logic to :
io.servicecomb.swagger.generator.core.utils.ClassUtils.correctMethodParameterName(String)

and following code can be optimized:
io.servicecomb.swagger.generator.core.utils.ClassUtils.JAVA_RESERVED_WORDS
io.servicecomb.swagger.generator.core.utils.ClassUtils.correctClassName(String)

Copy link
Contributor

@liubao68 liubao68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix review comments

@acsukesh
Copy link
Contributor Author

acsukesh commented Jan 9, 2018

@wujimin comments fixed. Will add IT and update PR.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 87.442% when pulling 377fe88 on acsukesh:master into e812ad7 on apache:master.

@acsukesh acsukesh closed this Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants