SCB-315 Config Center module can't get config by DynamicPropertyFacto… #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry.getInstance().getStringProperty, so has to use ConcurrentCompositeConfiguration
wujimin
reviewed
Feb 3, 2018
| "addressResolver." + tag + ".rotateServers", | ||
| "addressResolver.rotateServers")); | ||
| return addressResolverOptions; | ||
| } | ||
|
|
||
| private static List<String> getStringListProperty(List<String> defaultValue, String... keys) { | ||
| private static List<String> getStringListProperty(ConcurrentCompositeConfiguration configSource, | ||
| List<String> defaultValue, String... keys) { | ||
| String property = null; |
There was a problem hiding this comment.
if configSource is null, then assign from DynamicPropertyFactory.getBackingConfigurationSource()
then return Arrays.asList(configSource.getStringArray(key))
wujimin
reviewed
Feb 3, 2018
| @@ -95,33 +127,55 @@ public static AddressResolverOptions getAddressResover(String tag) { | |||
| } | |||
| } | |||
|
|
|||
| private static int getIntProperty(int defaultValue, String... keys) { | |||
| private static int getIntProperty(ConcurrentCompositeConfiguration configSource, int defaultValue, String... keys) { | |||
There was a problem hiding this comment.
we can make the logics simpler
…ry.getInstance().getStringProperty, so has to use ConcurrentCompositeConfiguration
wujimin
reviewed
Feb 3, 2018
| if (property > 0) { | ||
| break; | ||
| Integer val = configSource.getInteger(key, null); | ||
| if (val != null && val > 0) { |
There was a problem hiding this comment.
why a value <=0 is invalid?
There was a problem hiding this comment.
all integer parameters must large than zero
There was a problem hiding this comment.
1.if there is some property have no this limit
and developers see there is a getIntProperty method, invoke it directly......
2.users make a wrong configuration, here ignore the wrong value, and use default value
but this behavior is silence
nobody know what happened.
…ry.getInstance().getStringProperty, so has to use ConcurrentCompositeConfiguration
wujimin
approved these changes
Feb 3, 2018
WillemJiang
approved these changes
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ry.getInstance().getStringProperty, so has to use ConcurrentCompositeConfiguration
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.