[SCB-352] refactor QpsControllerManager, support operation level qps controll on provider side #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhs0092
changed the title
liubao68
reviewed
Mar 8, 2018
| // create "microservice" | ||
| createQpsControllerIfNotExist(qualifiedNameKey.substring(0, qualifiedNameKey.indexOf(SEPARATOR))); | ||
| // create "microservice.schema" | ||
| createQpsControllerIfNotExist(qualifiedNameKey.substring(0, qualifiedNameKey.lastIndexOf(SEPARATOR))); |
There was a problem hiding this comment.
We need to add naming conventions to docs of service name, schema and operation
There was a problem hiding this comment.
OK. I will add naming convention instructions in gitbook later.
liubao68
approved these changes
Mar 8, 2018
yhs0092
force-pushed
the
support_provider_operation_level_flow_control
branch
from
bc04967
to
f0a54d3
Compare
…ow control on provider side
yhs0092
force-pushed
the
support_provider_operation_level_flow_control
branch
from
f0a54d3
to
2e40314
Compare
wujimin
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Refactor QpsControllerManager and support operation level qps flow control on provider side.
https://issues.apache.org/jira/browse/SCB-352