Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-587] Fix archetypes readme #709

Merged
merged 2 commits into from May 18, 2018
Merged

Conversation

zhengyangyong
Copy link

@zhengyangyong zhengyangyong commented May 16, 2018

Signed-off-by: zhengyangyong yangyong.zheng@huawei.com

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

update generate from snapshot repo command

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@zhengyangyong zhengyangyong changed the title SCB-587 Fix archetypes readme [SCB-587] Fix archetypes readme May 16, 2018
@coveralls
Copy link

coveralls commented May 16, 2018

Coverage Status

Coverage increased (+0.005%) to 87.376% when pulling cf50718 on zhengyangyong:SCB-587 into 61cda00 on apache:master.

```bash
mvn archetype:generate -DarchetypeGroupId=org.apache.servicecomb.archetypes -DarchetypeArtifactId=business-service-jaxrs-archetype -DarchetypeVersion=${archetype-version} -DarchetypeRepository=https://repository.apache.org/content/groups/snapshots-group
mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate -DarchetypeGroupId=org.apache.servicecomb.archetypes -DarchetypeArtifactId=business-service-jaxrs-archetype -DarchetypeVersion=1.0.0-m2-SNAPSHOT -DarchetypeRepository=https://repository.apache.org/content/groups/snapshots-group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the old command, i succeeed to create project and run "mvn install"
(just copy and run, did no change anything, even did not replace ${archetype-version} to be 1.0.0-m2-SNAPSHOT)
so why we need to do this change?

and maybe this is a problem:
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ aid ---
[INFO] Changes detected - recompiling the module!
[WARNING] File encoding has not been set, using platform encoding GBK, i.e. build is platform dependent!
[INFO] Compiling 3 source files to D:\aid\target\classes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn archetype:generate may use latest version 3.0+ of archetype-plugin,archetypeRepository had deleted,https://maven.apache.org/archetype/maven-archetype-plugin/generate-mojo.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i see

but maybe encoding is a problem.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encoding problem PR : #710

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the release version we do need to specify the archetypeRepository.
I think it's better explain -DarchetypeXXX options to avoid making user confused.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@liubao68 liubao68 merged commit ebaf3ac into apache:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants