[SCB-591] configcenter need to do encode #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujimin
reviewed
May 17, 2018
| try { | ||
| encodeServiceName = URLEncoder.encode(serviceName, "UTF-8"); | ||
| } catch (UnsupportedEncodingException e1) { | ||
| e1.printStackTrace(); |
wujimin
reviewed
May 17, 2018
| } catch (UnsupportedEncodingException e1) { | ||
| e1.printStackTrace(); | ||
| } | ||
| String path = URIConst.ITEMS + "?dimensionsInfo=" + StringUtils.deleteWhitespace(encodeServiceName); |
There was a problem hiding this comment.
delete whitespace before or after encode?
wujimin
reviewed
May 18, 2018
| try { | ||
| encodeServiceName = URLEncoder.encode(StringUtils.deleteWhitespace(serviceName), "UTF-8"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| LOGGER.error("encode error: {}",e.getMessage()); |
There was a problem hiding this comment.
1.not format code
2.failed but still continue?
3."UTF-8" can changed to java.nio.charset.StandardCharsets.UTF_8.name()
There was a problem hiding this comment.
we can encoding serviceName in instance initialization if possible.
There was a problem hiding this comment.
ServiceName is stitched together in the CONFIG_CENTER_CONFIG.getServiceName() method，so you mean do encode in this method?
There was a problem hiding this comment.
format code,failed,UTF_8.name() have done.
liubao68
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.huawei's huangyun set up an agent to modify the special characters '#'，which led to the governance inoperative