[SCB-948] Convert proto model to string #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujimin
requested review from
WillemJiang,
zhengyangyong,
yangbor and
liubao68
liubao68
reviewed
Oct 11, 2018
| @@ -461,3 +461,4 @@ Zipkin Sender: OkHttp 3 (https://github.com/openzipkin/zipkin-reporter-java/zipk | |||
| Zipkin v1 (https://github.com/openzipkin/zipkin/) io.zipkin.java:zipkin:jar:2.4.2 | |||
| Zipkin v2 (https://github.com/openzipkin/zipkin/) io.zipkin.zipkin2:zipkin:jar:2.4.2 | |||
| zuul-core (https://github.com/Netflix/zuul) com.netflix.zuul:zuul-core:jar:1.3.0 | |||
| protobuf-java (https://github.com/protocolbuffers/protobuf/tree/master/java) com.google.protobuf:protobuf-java:jar:3.6.1 | |||
There was a problem hiding this comment.
This project does not using Apache License v2
There was a problem hiding this comment.
it's 3-Clause BSD license
fixed
wujimin
force-pushed
the
convert-proto-model-to-string
branch
from
138940c
to
32a1eb5
Compare
wujimin
force-pushed
the
convert-proto-model-to-string
branch
from
32a1eb5
to
55451c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.