refactor apis #129
Merged
refactor apis #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhulijian <zhulijian1@huawei.com>
tianxiaoliang
requested changes
Mar 26, 2020
server/resource/v1/kv_resource.go
Outdated
| if err != nil { | ||
| openlogging.Error(fmt.Sprintf("post [%v] err:%s", kvDoc, err.Error())) | ||
| if err == session.ErrKVAlreadyExists { | ||
| WriteErrResponse(context, http.StatusConflict, err.Error(), common.ContentTypeText) |
There was a problem hiding this comment.
WriteErrResponse这个函数以前写的有问题，MIME其实应该写死json
| @@ -43,11 +43,13 @@ var ( | |||
| //KV provide api of KV entity | |||
| type KV interface { | |||
| //below 3 methods is usually for admin console | |||
| Create(ctx context.Context, kv *model.KVDoc) (*model.KVDoc, error) | |||
There was a problem hiding this comment.
建议保持createorupdate语义，简洁，内部只需要小改动，而且你不用改UT了
|
resource层UT别忘了改 |
zhulijian1
force-pushed
the
refactor
branch
2 times, most recently
from
5a3b59f
to
ed2a1e4
Compare
tianxiaoliang
requested changes
Mar 27, 2020
Signed-off-by: zhulijian <zhulijian1@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改原因：
Fixes #130
修改内容：
重构kv相关API，包括：
修改后查询有两种方式：
一种： GET /kv/{kv_id} 通过kv_id查询唯一kv，查不到返回404，立即返回，不支持watch。
另一种： GET /kv?key={key}&label=xxxx... 查询符合条件的kv List，与原来API的/kv/{key}?label=xxxx...功能一致，只是参数key从path中移到了query中。查不到返回是200。支持watch。