#79 record polling history #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianxiaoliang
requested changes
Feb 12, 2020
tianxiaoliang
requested changes
Feb 12, 2020
# Conflicts: # server/resource/v1/kv_resource.go
tianxiaoliang
requested changes
Feb 12, 2020
| return | ||
| } | ||
| rctx.ReadResponseWriter().Header().Set(common.HeaderRevision, strconv.FormatInt(rev, 10)) | ||
| err = writeResponse(rctx, kv) | ||
| if err != nil { | ||
| openlogging.Error(err.Error()) | ||
| } | ||
| respData, _ := json.Marshal(kv) |
| return | ||
| } | ||
| rctx.ReadResponseWriter().Header().Set(common.HeaderRevision, strconv.FormatInt(rev, 10)) | ||
| err = writeResponse(rctx, kv) | ||
| if err != nil { | ||
| openlogging.Error(err.Error()) | ||
| } | ||
| respData, _ := json.Marshal(kv) | ||
| respHeader, _ := json.Marshal(rctx.Resp.Header()) |
| bsonType: "string" | ||
| }, | ||
| response_body: { | ||
| bsonType: "string" |
There was a problem hiding this comment.
不应该是个string应该是个bson object
| bsonType: "string" | ||
| }, | ||
| response_header: { | ||
| bsonType: "string" |
There was a problem hiding this comment.
不应该是个string应该是个bson object
tianxiaoliang
requested changes
Feb 12, 2020
| IP string `json:"ip,omitempty" yaml:"ip,omitempty"` | ||
| UserAgent string `json:"user_agent,omitempty" yaml:"user_agent,omitempty"` | ||
| URLPath string `json:"url_path,omitempty" yaml:"url_path,omitempty"` | ||
| ResponseBody string `json:"response_body,omitempty" yaml:"response_body,omitempty"` |
There was a problem hiding this comment.
ResponseBody 用 struct
| UserAgent string `json:"user_agent,omitempty" yaml:"user_agent,omitempty"` | ||
| URLPath string `json:"url_path,omitempty" yaml:"url_path,omitempty"` | ||
| ResponseBody string `json:"response_body,omitempty" yaml:"response_body,omitempty"` | ||
| ResponseHeader string `json:"response_header,omitempty" yaml:"response_header,omitempty"` |
There was a problem hiding this comment.
ResponseHeader 用map[string][]string
| @@ -64,6 +65,12 @@ type Label interface { | |||
| CreateOrUpdate(ctx context.Context, label *model.LabelDoc) (*model.LabelDoc, error) | |||
| } | |||
|
|
|||
| //Record manages record data | |||
| type Record interface { | |||
There was a problem hiding this comment.
Record 就叫PollingRecorder
| @@ -64,6 +65,12 @@ type Label interface { | |||
| CreateOrUpdate(ctx context.Context, label *model.LabelDoc) (*model.LabelDoc, error) | |||
| } | |||
|
|
|||
| //Record manages record data | |||
| type Record interface { | |||
| RecordSuccess(ctx context.Context, detail *model.PollingDetail, respStatus int, respData, respHeader string) (*model.PollingDetail, error) | |||
There was a problem hiding this comment.
没必要搞2个func 合成一个，非必填参数用functional options
| ) | ||
|
|
||
| //CreateOrUpdateRecord create a record or update exist record | ||
| func CreateOrUpdateRecord(ctx context.Context, detail *model.PollingDetail) (*model.PollingDetail, error) { |
There was a problem hiding this comment.
Record这个尾椎多余，要时刻考虑clean code，这里有上下文了
| return | ||
| } | ||
| rctx.WriteHeader(http.StatusNotModified) | ||
| return | ||
| _, recordErr = service.RecordService.RecordSuccess(rctx.Ctx, recordData, http.StatusNotModified, "", "") |
There was a problem hiding this comment.
太多地方需要考虑调用，不如用defer+一个func，虽然损失性能，但是优雅易维护
| @@ -138,21 +141,24 @@ func (r *KVResource) List(rctx *restful.Context) { | |||
| WriteErrResponse(rctx, http.StatusBadRequest, err.Error(), common.ContentTypeText) | |||
| return | |||
| } | |||
| insID := rctx.ReadHeader("insId") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.