[SCB-935] Saga transaction management console UI initial commit #317

anvithks · 2018-09-28T06:43:11Z

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

//TODO

Apache license compatibility check
Saga Web API server
List transaction tracing

coveralls · 2018-09-28T07:09:17Z

Coverage increased (+0.3%) to 92.097% when pulling 4b2b65f on anvithks:frontend-dev into bb34ce7 on apache:master.

WillemJiang · 2018-09-28T13:52:11Z

@anvithks After went through the PR, I found you may just copy https://github.com/akveo/ngx-admin/tree/starter-kit code here. I'm not sure if it's best way to do it, but need to make sure it works with Apache License first.

WillemJiang · 2018-09-28T13:55:41Z

BTW, we can need to create a module of UI first, then put the compiled js into the static resource directory of the saga-web.

anvithks · 2018-10-16T10:36:34Z

@anvithks After went through the PR, I found you may just copy https://github.com/akveo/ngx-admin/tree/starter-kit code here. I'm not sure if it's best way to do it, but need to make sure it works with Apache License first.

@WillemJiang sorry for the delayed response. I was on planned vacation and could not check on this.
Yes, you are right we can use the starter kit but it does not have many of the UI components that we have used in the UI. I will check if I can start with the starter-kit and add our modules. Let me get back to you on that.

anvithks · 2018-10-16T10:37:52Z

BTW, we can need to create a module of UI first, then put the compiled js into the static resource directory of the saga-web.

I will write an install script for the UI. This script will compile the UI from the source and copy the contents of the dist/ folder in to the static/ folder.

saga-web/src/main/resources/saga-frontend/package.json

asifdxtreme · 2018-10-17T04:58:09Z

// TODO (Mandatory before the PR merge)

For New dependencies following things should be done

Add the license copies in this directory
Add the Usage information over here
Add the Usage information with the version number over here

saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/sample/sample.layout.scss

saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/sample/sample.layout.ts

saga-web/src/main/resources/saga-frontend/src/assets/data/events.json

saga-web/src/main/resources/saga-frontend/tslint.json

asifdxtreme · 2018-10-17T05:13:36Z

@anvithks please replace favicon.* with ServiceComb icons, you can get it in this project

anvithks · 2018-10-17T11:15:39Z

@anvithks After went through the PR, I found you may just copy https://github.com/akveo/ngx-admin/tree/starter-kit code here. I'm not sure if it's best way to do it, but need to make sure it works with Apache License first.

@WillemJiang sorry for the delayed response. I was on planned vacation and could not check on this.
Yes, you are right we can use the starter kit but it does not have many of the UI components that we have used in the UI. I will check if I can start with the starter-kit and add our modules. Let me get back to you on that.

@WillemJiang after checking the code base of the starter kit and the one in the commit I find that I am using even lesser modules and components than the starter-kit. I have further reduced the LOC by removing some more unused files.

WillemJiang · 2018-10-26T01:51:30Z

@anvithks After went through the PR, I found you may just copy https://github.com/akveo/ngx-admin/tree/starter-kit code here. I'm not sure if it's best way to do it, but need to make sure it works with Apache License first.

@WillemJiang sorry for the delayed response. I was on planned vacation and could not check on this.
Yes, you are right we can use the starter kit but it does not have many of the UI components that we have used in the UI. I will check if I can start with the starter-kit and add our modules. Let me get back to you on that.

@WillemJiang after checking the code base of the starter kit and the one in the commit I find that I am using even lesser modules and components than the starter-kit. I have further reduced the LOC by removing some more unused files.

@anvithks Could you remove the unused file first?

anvithks · 2018-10-27T08:44:56Z

@WillemJiang It's done.

WillemJiang · 2018-11-13T10:52:06Z

saga-web/src/main/resources/saga-frontend/src/app/@core/core.module.ts

@@ -0,0 +1,75 @@
+import { ModuleWithProviders, NgModule, Optional, SkipSelf } from '@angular/core';


I need to know if this file is generated or write by hand.
If it is write by hand we need to apply the apache License header here.
If not, we should find a right way to specify the license.

Updated the files with appropriate license information.

asifdxtreme · 2018-12-03T10:28:57Z

@anvithks Please add ASF headers to all the files written by you, for format you can refer to https://github.com/apache/servicecomb-service-center/blob/master/frontend/app/index.html#L1

WillemJiang · 2018-12-10T01:39:30Z

@anvithks @asifdxtreme We are plan to do the release of ServiceComb at the end of this month, Please update the License header ASAP.

saga-web/src/main/resources/saga-frontend/README.md

saga-web/src/main/resources/saga-frontend/src/app/@core/utils/util.service.ts

saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/default/default.layout.scss

saga-web/src/main/resources/saga-frontend/src/app/app.module.ts

saga-demo/saga-servicecomb-demo/docker-compose.yaml

saga-web/src/main/resources/saga-frontend/src/app/@theme/styles/styles.scss

WillemJiang · 2018-12-11T06:04:32Z

@anvithks As there are bunch of code in this PR, do you mind fill an iCLA first. I'd happy merge it into the repository once receiving the iCLA notification.

asifdxtreme · 2018-12-11T06:24:47Z

@anvithks As there are bunch of code in this PR, do you mind fill an iCLA first. I'd happy merge it into the repository once receiving the iCLA notification.

I remember I have already sent ICLA of anvith sometime back

WillemJiang · 2018-12-11T07:31:54Z

@anvithks As there are bunch of code in this PR, do you mind fill an iCLA first. I'd happy merge it into the repository once receiving the iCLA notification.

I remember I have already sent ICLA of anvith sometime back

I found the iCLA acknowledge mail. The PR is good to go.

anvithks · 2018-12-11T10:22:56Z

// TODO (Mandatory before the PR merge)

For New dependencies following things should be done

[*] Add the license copies in this directory

[*] Add the Usage information over here

[*] Add the Usage information with the version number over here

@asifdxtreme these are fixed

asifdxtreme · 2018-12-11T11:20:32Z

saga-web/src/main/resources/saga-frontend/LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)


@anvithks We can remove this license now, this will now be added as a part of release/license

@asifdxtreme This is fixed

asifdxtreme · 2018-12-11T12:04:32Z

@WillemJiang After running RAT tool on this code below are the list of files which shows abnormal license eventhough licenses has been added in *.scss files

saga-web/src/main/resources/saga-frontend/README.md
saga-web/src/main/resources/saga-frontend/angular.json
saga-web/src/main/resources/saga-frontend/package.json
saga-web/src/main/resources/saga-frontend/tsconfig.json
saga-web/src/main/resources/saga-frontend/src/index.html
saga-web/src/main/resources/saga-frontend/src/tsconfig.app.json
saga-web/src/main/resources/saga-frontend/src/app/@theme/components/footer/footer.component.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/components/header/header.component.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/components/switcher/switcher.component.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/components/theme-settings/theme-settings.component.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/components/theme-switcher/theme-switcher.component.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/components/theme-switcher/themes-switcher-list/theme-switcher-list.component.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/one-column/one-column.layout.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/styles/bootstrap-rtl.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/styles/font-size.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/styles/pace.theme.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/styles/styles.scss
saga-web/src/main/resources/saga-frontend/src/app/@theme/styles/themes.scss
saga-web/src/main/resources/saga-frontend/src/app/pages/miscellaneous/not-found/not-found.component.scss
saga-web/src/main/resources/saga-frontend/src/assets/images/square_pattern.svg
saga-web/src/main/resources/saga-frontend/src/assets/images/square_pattern_cosmic.svg

Please confirm if we can go ahead with it?

WillemJiang · 2018-12-12T08:59:15Z

I think we can leave the json and svg files there, but I'm not sure about the scss files.
@asifdxtreme Do you have any idea about that?

asifdxtreme · 2018-12-12T09:02:19Z

I think we can leave the json and svg files there, but I'm not sure about the scss files.
@asifdxtreme Do you have any idea about that?

@WillemJiang these scss files have the License but RAT tool is not able to detect it

asifdxtreme · 2018-12-12T10:23:36Z

@WillemJiang The Rat report after running it on latest changes is here

/saga-web/src/main/resources/saga-frontend/README.md
/saga-web/src/main/resources/saga-frontend/angular.json
/saga-web/src/main/resources/saga-frontend/package.json
/saga-web/src/main/resources/saga-frontend/tsconfig.json
/saga-web/src/main/resources/saga-frontend/src/tsconfig.app.json
/saga-web/src/main/resources/saga-frontend/src/assets/images/square_pattern.svg
/saga-web/src/main/resources/saga-frontend/src/assets/images/square_pattern_cosmic.svg

WillemJiang · 2018-12-13T10:14:31Z

...eb/src/main/resources/saga-frontend/src/app/@theme/components/switcher/switcher.component.ts

@@ -1,7 +1,7 @@
 /**
 * @license
 * Copyright Akveo. All Rights Reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Licensed under the MIT License. See licenses/LICENSE-ngxadmin for license information.


I don't think the reference of LICENSE is clean enough.

@WillemJiang lets discuss how best we can do this. I will make the changes as needed in the next PR.

WillemJiang · 2018-12-14T02:07:07Z

As we need to do some clean up of the saga-pack repo. I merged the PR first, we can polish the License header in another PR.

@anvithks Please put the JIRA ID in the comments next for tracking the committer in a better way.
Now I had to squash your commit to update the commit message.

anvithks · 2018-12-14T08:19:59Z

As we need to do some clean up of the saga-pack repo. I merged the PR first, we can polish the License header in another PR.

@anvithks Please put the JIRA ID in the comments next for tracking the committer in a better way.
Now I had to squash your commit to update the commit message.

@WillemJiang Did you mean adding JIRA ID to commit messages or any further comments?
I will do the needful.

WillemJiang · 2018-12-14T09:10:04Z

@anvithks I mean adding the JIRA ID to the first line of commit log, in this way we could grep the committees which is related to the JIRA ID. It's quite useful when we need to cherry pick different patches between different branches.

asifdxtreme requested a review from WillemJiang September 28, 2018 06:53

anvithks force-pushed the frontend-dev branch from 9f2baae to 91404b0 Compare October 16, 2018 12:02

asifdxtreme reviewed Oct 17, 2018

View reviewed changes

saga-web/src/main/resources/saga-frontend/package.json Outdated Show resolved Hide resolved

asifdxtreme requested changes Oct 17, 2018

View reviewed changes

Saga transaction management console UI initial commit

0576a9b

anvithks force-pushed the frontend-dev branch from 91404b0 to 0576a9b Compare October 17, 2018 09:08

Removed unnecessary files and updated the icons.

55c6b51

asifdxtreme approved these changes Oct 17, 2018

View reviewed changes

zhfeng added the need to fix label Oct 26, 2018

asifdxtreme mentioned this pull request Oct 30, 2018

SCB-995 Implement Saga Console API's #325

Merged

6 tasks

WillemJiang reviewed Nov 13, 2018

View reviewed changes

anvithks added 3 commits November 22, 2018 13:15

Updated dashboard as per new ALpha API's.

83e61a2

Fixed some UI style issues.

e21ce3b

Fixed spelling error.

b7ca4d9

asifdxtreme requested changes Dec 10, 2018

View reviewed changes

Updated ASF headers. removed commented code.

23deb1d

asifdxtreme reviewed Dec 10, 2018

View reviewed changes

saga-demo/saga-servicecomb-demo/docker-compose.yaml Outdated Show resolved Hide resolved

anvithks added 2 commits December 10, 2018 14:21

Docker image reference changed.

3159d52

Updated the Readme file.

61a8d24

asifdxtreme requested changes Dec 10, 2018

View reviewed changes

saga-web/src/main/resources/saga-frontend/src/app/@theme/styles/styles.scss Show resolved Hide resolved

Added missing license information

f8a11cd

asifdxtreme approved these changes Dec 11, 2018

View reviewed changes

Added license copies. Added usage information and version number.

2a2f31f

asifdxtreme changed the title ~~[SCB-935] [WIP] Saga transaction management console UI initial commit~~ [SCB-935] Saga transaction management console UI initial commit Dec 11, 2018

asifdxtreme reviewed Dec 11, 2018

View reviewed changes

Updated license information in the scss files.

4b2b65f

anvithks force-pushed the frontend-dev branch from 5ddca13 to 4b2b65f Compare December 12, 2018 11:32

WillemJiang reviewed Dec 13, 2018

View reviewed changes

WillemJiang merged commit 96b1514 into apache:master Dec 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SCB-935] Saga transaction management console UI initial commit #317

[SCB-935] Saga transaction management console UI initial commit #317

anvithks commented Sep 28, 2018 •

edited by asifdxtreme

coveralls commented Sep 28, 2018 •

edited

WillemJiang commented Sep 28, 2018

WillemJiang commented Sep 28, 2018

anvithks commented Oct 16, 2018

anvithks commented Oct 16, 2018

asifdxtreme commented Oct 17, 2018

asifdxtreme commented Oct 17, 2018

anvithks commented Oct 17, 2018

WillemJiang commented Oct 26, 2018

anvithks commented Oct 27, 2018

WillemJiang Nov 13, 2018 •

edited

anvithks Dec 11, 2018

asifdxtreme commented Dec 3, 2018

WillemJiang commented Dec 10, 2018

WillemJiang commented Dec 11, 2018

asifdxtreme commented Dec 11, 2018 •

edited

WillemJiang commented Dec 11, 2018

anvithks commented Dec 11, 2018

// TODO (Mandatory before the PR merge)

asifdxtreme Dec 11, 2018

anvithks Dec 12, 2018

asifdxtreme commented Dec 11, 2018

WillemJiang commented Dec 12, 2018

asifdxtreme commented Dec 12, 2018

asifdxtreme commented Dec 12, 2018 •

edited

WillemJiang Dec 13, 2018

anvithks Dec 14, 2018

WillemJiang commented Dec 14, 2018 •

edited

anvithks commented Dec 14, 2018

WillemJiang commented Dec 14, 2018

		@@ -0,0 +1,75 @@
		import { ModuleWithProviders, NgModule, Optional, SkipSelf } from '@angular/core';

[SCB-935] Saga transaction management console UI initial commit #317

[SCB-935] Saga transaction management console UI initial commit #317

Conversation

anvithks commented Sep 28, 2018 • edited by asifdxtreme

coveralls commented Sep 28, 2018 • edited

WillemJiang commented Sep 28, 2018

WillemJiang commented Sep 28, 2018

anvithks commented Oct 16, 2018

anvithks commented Oct 16, 2018

asifdxtreme commented Oct 17, 2018

// TODO (Mandatory before the PR merge)

asifdxtreme commented Oct 17, 2018

anvithks commented Oct 17, 2018

WillemJiang commented Oct 26, 2018

anvithks commented Oct 27, 2018

WillemJiang Nov 13, 2018 • edited

Choose a reason for hiding this comment

anvithks Dec 11, 2018

Choose a reason for hiding this comment

asifdxtreme commented Dec 3, 2018

WillemJiang commented Dec 10, 2018

WillemJiang commented Dec 11, 2018

asifdxtreme commented Dec 11, 2018 • edited

WillemJiang commented Dec 11, 2018

anvithks commented Dec 11, 2018

// TODO (Mandatory before the PR merge)

asifdxtreme Dec 11, 2018

Choose a reason for hiding this comment

anvithks Dec 12, 2018

Choose a reason for hiding this comment

asifdxtreme commented Dec 11, 2018

WillemJiang commented Dec 12, 2018

asifdxtreme commented Dec 12, 2018

asifdxtreme commented Dec 12, 2018 • edited

WillemJiang Dec 13, 2018

Choose a reason for hiding this comment

anvithks Dec 14, 2018

Choose a reason for hiding this comment

WillemJiang commented Dec 14, 2018 • edited

anvithks commented Dec 14, 2018

WillemJiang commented Dec 14, 2018

anvithks commented Sep 28, 2018 •

edited by asifdxtreme

coveralls commented Sep 28, 2018 •

edited

WillemJiang Nov 13, 2018 •

edited

asifdxtreme commented Dec 11, 2018 •

edited

asifdxtreme commented Dec 12, 2018 •

edited

WillemJiang commented Dec 14, 2018 •

edited