Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCB-1195] Modify eureka.enabled to eureka.client.enabled #426

Merged
merged 1 commit into from Mar 13, 2019
Merged

[SCB-1195] Modify eureka.enabled to eureka.client.enabled #426

merged 1 commit into from Mar 13, 2019

Conversation

coolbeevip
Copy link
Member

No description provided.

WillemJiang
WillemJiang reviewed Mar 13, 2019
View reviewed changes
Copy link
Member

@WillemJiang WillemJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we do this change? Can you explain it?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 90.294% when pulling bd50ea2 on coolbeevip:SCB-1195 into c7a0b4c on apache:master.

@coolbeevip
Copy link
Member Author

coolbeevip commented Mar 13, 2019 •
edited

Why do we do this change? Can you explain it?

Wrong before, eureka.client.enabled is the correct eureka parameter.
You can find it on https://cloud.spring.io/spring-cloud-netflix/spring-cloud-netflix.html

@WillemJiang WillemJiang merged commit 96cc745 into apache:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillemJiang WillemJiang WillemJiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coolbeevip @coveralls @WillemJiang