Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-1352 Fix typo on ParametersContext class #489

Merged
merged 1 commit into from Jul 6, 2019
Merged

SCB-1352 Fix typo on ParametersContext class #489

merged 1 commit into from Jul 6, 2019

Conversation

chanjarster
Copy link
Member

@chanjarster chanjarster commented Jul 4, 2019

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Change ParametersContext.putParamters to putParameters

@coveralls
Copy link

coveralls commented Jul 4, 2019

Coverage Status

Coverage increased (+0.04%) to 89.349% when pulling 66d59dc on chanjarster:fixtypo into bcf978d on apache:master.

@coolbeevip
Copy link
Member

Thanks for your contribution.

@WillemJiang WillemJiang changed the title Fix typo on ParametersContext class SCB-1352 Fix typo on ParametersContext class Jul 6, 2019
Copy link
Member

@WillemJiang WillemJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just add a JIRA number for it, so we can track it in our release note.

@WillemJiang
Copy link
Member

As the putParameters method is internal API and it's rarely used by the user, I think it's safe to change the method name.

@WillemJiang WillemJiang merged commit 5a711dd into apache:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants