[SCB-2205] Polishing Github actions workflow #703
Conversation
coolbeevip
changed the title
coolbeevip
changed the title
coolbeevip
force-pushed
the
SCB-2205
branch
2 times, most recently
from
e0204a5
to
fbceed2
Compare
coolbeevip
changed the title
|
LGTM |
| run: git log -n1 | ||
| - name: Build and test | ||
| if: ${{ success() }} | ||
| run: ./mvnw clean install -B -Pjacoco -Pdocker coveralls:report -DrepoToken=ftogh57jTQ0GRa4AaOgFfltiUrwnO8tw9 |
There was a problem hiding this comment.
The token string should be used in environment variables ?
There was a problem hiding this comment.
The token string should be used in environment variables ?
secrets are not passed to the runner when a workflow is triggered from a forked repository.
As GitHub stuff answered here
There was a problem hiding this comment.
OK, I see. so is there any other problem we provide the token in plain text here ? this token could be changed in the future ?
There was a problem hiding this comment.
The token has been set to GitHub secrets with https://issues.apache.org/jira/browse/INFRA-21569 and uses secrets.COVERALLS_TOKEN in push workflow.
If we do not analyze the coverage in the pull request, we can remove the plaintext token
There was a problem hiding this comment.
hmm, I prefer to disable the coverage in PR now and see if we can have a better solution in the future. How do you think @WillemJiang
There was a problem hiding this comment.
hmm, I prefer to disable the coverage in PR now and see if we can have a better solution in the future. How do you think @WillemJiang
I removed the Coveralls report token from the pull request script
| jobs: | ||
| mvn: | ||
| timeout-minutes: 180 | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
why we stick on this ubuntu version 20.04, it can be the 'lastest' ?
There was a problem hiding this comment.
it's better to specify the ubuntu version.
There was a problem hiding this comment.
Yep, Ubuntu-latest workflows will use Ubuntu-20.04
| # | 1 | Sean | 5 | true | false | | ||
| # | ||
| # Then Hotel Service contains the following booking orders | ||
| # | id | name | amount | confirmed | cancelled | |
There was a problem hiding this comment.
why we disable this scenario ?
There was a problem hiding this comment.
This is an unstable test case, I created a JIRA https://issues.apache.org/jira/browse/SCB-2204 for it
There was a problem hiding this comment.
Thanks - please add the JIRA issue link here and we can track it easier
There was a problem hiding this comment.
Thanks - please add the JIRA issue link here and we can track it easier
done
Occasionally fail on poor performance CI. I created a JIRA https://issues.apache.org/jira/browse/SCB-2204 for it
ci.yamltoprandpushscript