Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-995 Implement Saga Console API's #325

Merged
merged 1 commit into from Nov 13, 2018
Merged

Conversation

asifdxtreme
Copy link
Member

This set of API's has been implemented to expose the saga events through API's which can be used by Saga Dashboard.

This PR is in continuation of the #317

API Documentation for these API's are available here

Postman Collection for these API 's are available here

An Alpha-Server image with these changes are available here for test.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 89.896% when pulling 9ea0bc1 on asifdxtreme:master into 1e7d762 on apache:master.

@WillemJiang
Copy link
Member

WillemJiang commented Oct 31, 2018

@asifdxtreme Please add unit test for the code. I also added some comments on the query API.

@asifdxtreme
Copy link
Member Author

@asifdxtreme Please add unit test for the code. I also added some comments on the query API.

@WillemJiang thanks for the suggestion, I will add the duration parameter in the findTransaction API by which user can find the list of all transactions in happened in that duration.

One more thing, here in this complete set of API's I consider Global Transactions as 1 transaction and not the sub transactions, means if there is 5 Global transactions and each global transactions have 3 sub-transactions then the totalTransaction count as per my API will be 5 and not 15.

@WillemJiang WillemJiang merged commit 10cdd07 into apache:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants