Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-2176 Add resource application #1008

Merged
merged 3 commits into from
May 26, 2021
Merged

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
  • Never comment source code, delete it.
  • UT should has "context, subject, expected result" result as test case name, when you call t.Run().

@little-cui little-cui force-pushed the rbac branch 3 times, most recently from 0c4af2c to 8cc612a Compare May 26, 2021 06:21
package auth

// Application is the resource application parsed from request
type Application struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改名为ResourceScope更加好理解,能够访问的目标资源范围

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@little-cui little-cui force-pushed the rbac branch 2 times, most recently from dd3100c to 098b62f Compare May 26, 2021 06:28
@little-cui little-cui force-pushed the rbac branch 4 times, most recently from c33f207 to fb99c35 Compare May 26, 2021 07:19
@tianxiaoliang tianxiaoliang merged commit 308773e into apache:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants