SCB-2176 Support wildcard filter #1010

little-cui · 2021-05-26T07:59:28Z

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
If this contribution is large, please file an Apache Individual Contributor License Agreement.
Never comment source code, delete it.
UT should has "context, subject, expected result" result as test case name, when you call t.Run().

tianxiaoliang · 2021-05-26T09:07:13Z

pkg/util/wildcard_test.go

+	t.Run("not regexp should match exactly", func(t *testing.T) {
+		assert.True(t, util.WildcardMatch("TestA", "TestA"))
+	})
+


简单API，下次用gotests自动生成测试代码

SCB-2176 Support wildcard filter

0c3fb5c

tianxiaoliang approved these changes May 26, 2021

View reviewed changes

tianxiaoliang merged commit 5d2a92e into apache:master May 26, 2021

Provide feedback