Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Etcd metrics not correct #1155

Merged
merged 2 commits into from Sep 27, 2021
Merged

Fix: Etcd metrics not correct #1155

merged 2 commits into from Sep 27, 2021

Conversation

little-cui
Copy link
Member

@little-cui little-cui commented Sep 26, 2021

背景描述:metrics是基于事件驱动计数的,但由于缓存增加了定时重置机制,如重置时刚好发生了实例变化,这样会导致metrics计算错误
修复方案:重构metrics机制为定期计算。

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
  • Never comment source code, delete it.
  • UT should has "context, subject, expected result" result as test case name, when you call t.Run().

@tianxiaoliang
Copy link
Contributor

记录修复思路

}

func (m *MetricsManager) Report(ctx context.Context, r *MetaReporter) error {
reportDomains(ctx, r)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个周期是多久一次,要可以配置,否则后续由于压力导致需要调整时,可能不会很方便

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以配置的

metrics:
  interval: 30s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants