Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] using cari's mongo db client #1233

Merged
merged 1 commit into from
Jan 19, 2022
Merged

[refactor] using cari's mongo db client #1233

merged 1 commit into from
Jan 19, 2022

Conversation

robotLJW
Copy link
Member

@robotLJW robotLJW commented Jan 19, 2022

【issue】#1227
【修改内容】:
1.sc中db的mongo,使用 cari 提供的 client
【修改原因】:
1、减少db的client创建
【影响范围】:无
【额外说明】:无
【测试用例】:
1、修改相关db的测试用例

@robotLJW robotLJW added enhancement feat new feature labels Jan 19, 2022
@@ -116,10 +116,6 @@ registry:
cluster:
uri: mongodb://127.0.0.1:27017
sslEnabled: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉sslEnabled,改用ssl.enable代替吧,原有的ssl.mode也废弃掉

test/test.go Outdated
@@ -55,7 +55,7 @@ func init() {
} else {
_ = archaius.Set("registry.heartbeat.kind", "checker")
kind = "mongo"
uri = "mongodb://127.0.0.1:27017"
uri = "mongodb://127.0.0.1:27010"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要改端口?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个忘记了,忘记本地调试用例忘记修改回来了

@robotLJW robotLJW merged commit e1db06b into apache:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants