Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-127 Bug fix: Can not discovery the same domain service instances. #234

Merged
merged 2 commits into from
Dec 28, 2017

Conversation

little-cui
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 72.489% when pulling cfda1a6 on little-cui:master into dec81c0 on apache:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 72.646% when pulling cfda1a6 on little-cui:master into dec81c0 on apache:master.

@codecov-io
Copy link

codecov-io commented Dec 28, 2017

Codecov Report

Merging #234 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   68.72%   68.86%   +0.14%     
==========================================
  Files          17       17              
  Lines        3562     3562              
==========================================
+ Hits         2448     2453       +5     
+ Misses        938      935       -3     
+ Partials      176      174       -2
Impacted Files Coverage Δ
server/service/instances.go 70.38% <100%> (-0.17%) ⬇️
server/service/tag.go 74.41% <0%> (+0.58%) ⬆️
server/service/microservices.go 73.63% <0%> (+0.78%) ⬆️
server/service/service_dependency.go 75.86% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dec81c0...cfda1a6. Read the comment docs.

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@asifdxtreme asifdxtreme merged commit a9637a4 into apache:master Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants