SCB-143 Add new rate limiter #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 68.72% 68.81% +0.08%
==========================================
Files 17 17
Lines 3562 3559 -3
==========================================
+ Hits 2448 2449 +1
+ Misses 938 936 -2
+ Partials 176 174 -2
Continue to review full report at Codecov.
|
little-cui
requested changes
Dec 29, 2017
pkg/httplimiter/httpratelimiter.go
Outdated
| limiter := &HttpLimiter{RequestLimit: max, TTL: ttl} | ||
| limiter.ContentType = "text/plain; charset=utf-8" | ||
| limiter.HttpMessage = "You have reached maximum request limit." | ||
| limiter.StatusCode = 429 |
There was a problem hiding this comment.
Use http.StatusTooManyRequests replace the magic number
pkg/httplimiter/httpratelimiter.go
Outdated
| w.Header().Add("X-Rate-Limit-Duration", limiter.TTL.String()) | ||
| } | ||
|
|
||
| func checkExsistence(sliceString []string, needle string) bool { |
There was a problem hiding this comment.
checkExsistence -> checkExistence
| if httpError != nil { | ||
| w.Header().Add("Content-Type", this.tbLimiter.MessageContentType) | ||
| w.Header().Add("Content-Type", this.httpLimiter.ContentType) | ||
| w.WriteHeader(httpError.StatusCode) | ||
| w.Write(util.StringToBytesWithNoCopy(httpError.Message)) | ||
| util.Logger().Warn("Reached maximum request limit!", nil) |
There was a problem hiding this comment.
please log print the limit remote ip and request URI
|
@little-cui Thanks for reviewing, I have fixed the code based on your comments, kindle review... |
little-cui
approved these changes
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.