Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-127 Add shared service UT. #237

Merged
merged 1 commit into from
Dec 28, 2017
Merged

Conversation

little-cui
Copy link
Member

@little-cui little-cui commented Dec 28, 2017

(cherry picked from commit 8df3835)

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

(cherry picked from commit 8df3835)
@little-cui little-cui self-assigned this Dec 28, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 72.58% when pulling 375b051 on little-cui:master into 6e6c790 on apache:master.

@codecov-io
Copy link

Codecov Report

Merging #237 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   68.78%   68.89%   +0.11%     
==========================================
  Files          17       17              
  Lines        3559     3559              
==========================================
+ Hits         2448     2452       +4     
+ Misses        935      933       -2     
+ Partials      176      174       -2
Impacted Files Coverage Δ
server/service/instances.go 70.9% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6c790...375b051. Read the comment docs.

@little-cui little-cui merged commit a7c45de into apache:master Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants