Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-298 v4/default/govern/microservices return self microservice information #264

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…s doesn't return self microservice information
@little-cui little-cui self-assigned this Jan 29, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.832% when pulling 5d9b2af on little-cui:master into 2f3030b on apache:master.

@codecov-io
Copy link

Codecov Report

Merging #264 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #264      +/-   ##
=========================================
+ Coverage   70.17%   70.2%   +0.02%     
=========================================
  Files          17      17              
  Lines        3470    3470              
=========================================
+ Hits         2435    2436       +1     
  Misses        864     864              
+ Partials      171     170       -1
Impacted Files Coverage Δ
server/service/service_dependency.go 73.91% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3030b...5d9b2af. Read the comment docs.

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@asifdxtreme asifdxtreme merged commit 33bb13a into apache:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants