Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-317 Prepare the release for Service-Center-1.0.0-m1 #269

Merged
merged 2 commits into from Feb 2, 2018

Conversation

little-cui
Copy link
Member

(cherry picked from commit b16e646)

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

(cherry picked from commit b16e646)
@little-cui little-cui self-assigned this Feb 2, 2018
Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@codecov-io
Copy link

Codecov Report

Merging #269 into master will increase coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   70.17%   70.33%   +0.16%     
==========================================
  Files          17       17              
  Lines        3470     3418      -52     
==========================================
- Hits         2435     2404      -31     
+ Misses        864      846      -18     
+ Partials      171      168       -3
Impacted Files Coverage Δ
server/service/microservices.go 74.45% <ø> (+0.39%) ⬆️
server/service/util/dependency.go 57.58% <ø> (+0.41%) ⬆️
server/service/util/microservice_util.go 74.84% <0%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b0b3a...e34c978. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 73.895% when pulling e34c978 on little-cui:master into d6b0b3a on apache:master.

@little-cui little-cui merged commit 1d56c95 into apache:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants