Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-317 Update the cors license #273

Merged
merged 3 commits into from Feb 5, 2018
Merged

Conversation

asifdxtreme
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage decreased (-0.01%) to 73.876% when pulling 063d951 on asifdxtreme:cors into e9a498a on apache:master.

@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #273 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   70.33%   70.36%   +0.02%     
==========================================
  Files          17       17              
  Lines        3418     3418              
==========================================
+ Hits         2404     2405       +1     
  Misses        846      846              
+ Partials      168      167       -1
Impacted Files Coverage Δ
server/service/service_dependency.go 73.04% <0%> (ø) ⬆️
server/service/rule.go 76.82% <0%> (ø) ⬆️
server/service/instances.go 71.28% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a498a...063d951. Read the comment docs.

@@ -14,6 +14,28 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Apache License header as we can only put the Apache License header to the code which we have the copyright.

Copy link
Member

@WillemJiang WillemJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the ASL header of the cors.go, add a comment that you did some modification of the original code.

@asifdxtreme
Copy link
Member Author

@WillemJiang Thanks for the suggestion, I have removed the ASl header and added a comment that original code was modified to suit the Service-Center use case

@little-cui little-cui merged commit 6e1bb00 into apache:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants