New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCB-317 Update the cors license #273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 70.33% 70.36% +0.02%
==========================================
Files 17 17
Lines 3418 3418
==========================================
+ Hits 2404 2405 +1
Misses 846 846
+ Partials 168 167 -1
Continue to review full report at Codecov.
|
server/interceptor/cors/cors.go
Outdated
@@ -14,6 +14,28 @@ | |||
* See the License for the specific language governing permissions and | |||
* limitations under the License. | |||
*/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the Apache License header as we can only put the Apache License header to the code which we have the copyright.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the ASL header of the cors.go, add a comment that you did some modification of the original code.
@WillemJiang Thanks for the suggestion, I have removed the ASl header and added a comment that original code was modified to suit the Service-Center use case |
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles
, where you replaceSCB-XXX
with the appropriate JIRA issue.go build
go test
go fmt
go vet
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.