Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-391 SC does not rotate log file #304

Merged
merged 2 commits into from Mar 13, 2018
Merged

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Mar 12, 2018

Coverage Status

Coverage decreased (-0.4%) to 73.556% when pulling c52afc5 on little-cui:SCB-391 into bfe0666 on apache:master.

@codecov-io
Copy link

codecov-io commented Mar 12, 2018

Codecov Report

Merging #304 into master will decrease coverage by 0.54%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   70.39%   69.84%   -0.55%     
==========================================
  Files          17       17              
  Lines        3455     3455              
==========================================
- Hits         2432     2413      -19     
- Misses        853      872      +19     
  Partials      170      170
Impacted Files Coverage Δ
server/service/util/dependency.go 54.82% <0%> (-2.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe0666...c52afc5. Read the comment docs.

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asifdxtreme asifdxtreme merged commit 0b7c685 into apache:master Mar 13, 2018
@little-cui little-cui deleted the SCB-391 branch March 16, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants