Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-472 Null point reference in zipkin plugin #325

Merged
merged 7 commits into from Apr 13, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this Apr 10, 2018
@coveralls
Copy link

coveralls commented Apr 10, 2018

Coverage Status

Coverage decreased (-0.3%) to 73.039% when pulling 9400811 on little-cui:master into 7650f35 on apache:master.

@codecov-io
Copy link

codecov-io commented Apr 10, 2018

Codecov Report

Merging #325 into master will decrease coverage by 0.24%.
The diff coverage is 75.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   69.73%   69.48%   -0.25%     
==========================================
  Files          17       17              
  Lines        3426     3438      +12     
==========================================
  Hits         2389     2389              
- Misses        871      884      +13     
+ Partials      166      165       -1
Impacted Files Coverage Δ
server/service/util/dependency.go 56.54% <100%> (-1.24%) ⬇️
server/service/microservices.go 74.55% <63.15%> (-0.05%) ⬇️
server/service/instances.go 68.32% <85.71%> (-0.07%) ⬇️
server/service/tag.go 76.02% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7650f35...9400811. Read the comment docs.

@little-cui little-cui merged commit 6c4143c into apache:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants