Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-393 Retry to request etcd too frequently when fail #352

Merged
merged 8 commits into from May 17, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this May 17, 2018
@coveralls
Copy link

coveralls commented May 17, 2018

Coverage Status

Coverage decreased (-0.2%) to 73.206% when pulling c7f9bad on little-cui:master into 3618245 on apache:master.

@codecov-io
Copy link

codecov-io commented May 17, 2018

Codecov Report

Merging #352 into master will decrease coverage by 0.24%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
- Coverage   69.88%   69.64%   -0.25%     
==========================================
  Files          18       18              
  Lines        3420     3406      -14     
==========================================
- Hits         2390     2372      -18     
- Misses        865      868       +3     
- Partials      165      166       +1
Impacted Files Coverage Δ
server/service/instances.go 68.58% <ø> (-2.56%) ⬇️
server/service/util/heartbeat_util.go 80% <100%> (ø) ⬆️
server/service/microservices.go 74.55% <100%> (ø) ⬆️
server/service/util/tag_util.go 65.51% <100%> (ø) ⬆️
server/service/util/dependency.go 56.37% <100%> (ø) ⬆️
server/service/schema.go 75% <100%> (ø) ⬆️
server/service/util/microservice_util.go 74.84% <100%> (ø) ⬆️
server/service/util/domain_util.go 71.64% <100%> (ø) ⬆️
server/service/util/schema_util.go 87.5% <100%> (ø) ⬆️
server/service/util/rule_util.go 67.5% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3618245...c7f9bad. Read the comment docs.

@little-cui little-cui merged commit 0ebf06e into apache:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants