Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-1015 Support the forth microservice version number registration #488

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

Codecov Report

Merging #488 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   60.35%   60.35%           
=======================================
  Files         159      159           
  Lines       13534    13534           
=======================================
  Hits         8169     8169           
  Misses       4787     4787           
  Partials      578      578
Impacted Files Coverage Δ
server/service/util/versionrule.go 100% <100%> (ø) ⬆️
pkg/util/tree.go 81.25% <0%> (-3.13%) ⬇️
pkg/tlsutil/tlsutil.go 73.58% <0%> (-0.95%) ⬇️
server/service/instance.go 67.61% <0%> (-0.2%) ⬇️
server/broker/service.go 57.78% <0%> (-0.16%) ⬇️
server/broker/util.go 53.47% <0%> (+0.26%) ⬆️
pkg/log/logrotate.go 34.28% <0%> (+0.57%) ⬆️
scctl/pkg/plugin/diagnose/compare_holder.go 96.15% <0%> (+1.28%) ⬆️
server/service/util/tag_util.go 65.38% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f06f1...2d324cf. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 62.817% when pulling 2d324cf on little-cui:ver into c3f06f1 on apache:master.

@little-cui little-cui merged commit 09040b9 into apache:master Nov 14, 2018
@little-cui little-cui deleted the ver branch November 15, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants