Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-1059 Support go 1.11.2 #504

Merged
merged 1 commit into from Dec 3, 2018
Merged

SCB-1059 Support go 1.11.2 #504

merged 1 commit into from Dec 3, 2018

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this Dec 3, 2018
@coveralls
Copy link

coveralls commented Dec 3, 2018

Coverage Status

Coverage increased (+0.03%) to 61.822% when pulling 4863401 on little-cui:docker into 0e8562e on apache:master.

@codecov-io
Copy link

Codecov Report

Merging #504 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   59.34%   59.35%   +<.01%     
==========================================
  Files         166      166              
  Lines       13945    13945              
==========================================
+ Hits         8276     8277       +1     
  Misses       5081     5081              
+ Partials      588      587       -1
Impacted Files Coverage Δ
server/plugin/pkg/registry/etcd/tracing.go 72.72% <0%> (-9.1%) ⬇️
pkg/tlsutil/tlsutil.go 73.58% <0%> (-0.95%) ⬇️
server/broker/service.go 57.94% <0%> (+0.15%) ⬆️
server/broker/util.go 53.47% <0%> (+0.26%) ⬆️
server/govern/service.go 72.93% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8562e...4863401. Read the comment docs.

@little-cui little-cui merged commit 307132e into apache:master Dec 3, 2018
@little-cui little-cui deleted the docker branch December 3, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants