Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-1059 Should not show the shared microservices by default #528

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

little-cui
Copy link
Member

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@little-cui little-cui self-assigned this Jan 22, 2019
@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #528 into master will decrease coverage by 0.03%.
The diff coverage is 50.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   59.41%   59.38%   -0.04%     
==========================================
  Files         172      172              
  Lines       14235    14266      +31     
==========================================
+ Hits         8458     8472      +14     
- Misses       5189     5200      +11     
- Partials      588      594       +6
Impacted Files Coverage Δ
server/core/proto/services.pb.go 4.49% <0%> (-0.02%) ⬇️
server/govern/service.go 69.2% <39.13%> (-3.74%) ⬇️
server/govern/controller_v4.go 73.68% <85%> (+1.06%) ⬆️
server/service/util/dependency.go 46.87% <0%> (-1.57%) ⬇️
server/broker/service.go 57.94% <0%> (+0.15%) ⬆️
pkg/tlsutil/tlsutil.go 74.52% <0%> (+0.94%) ⬆️
server/notify/listwatcher.go 77.61% <0%> (+10.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5733168...55755eb. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 22, 2019

Coverage Status

Coverage increased (+0.04%) to 61.86% when pulling 55755eb on little-cui:govern into 5733168 on apache:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants