Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAV-42 update the readme #8

Closed
wants to merge 3 commits into from
Closed

JAV-42 update the readme #8

wants to merge 3 commits into from

Conversation

TankTian
Copy link
Contributor

No description provided.

README.md Outdated

A standalone Service Center to allow services to register their instance information and to discover providers of a given service

- [http://www.servicecomb.io/service-center](http://www.servicecomb.io/service-center)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this webpage is not ready. i suggest not putting the link here, or it may confuse readers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now , i remove it.

README.md Outdated

Project documentation is available on the ServiceComb website.

http://www.servicecomb.io/service-center/documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same suggestion as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, now , i remove it.


### Running Service Center

First, you need to run a etcd(version: 1.3.x) as a database service,and then modify the etcd IP and port in the Service Center configuration file (./conf/app.conf : manager_cluster).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this statement First, you need to run a etcd(version: 1.3.x) as a database service probably belongs to the design of service center.

It's better to put this information to a design section. users just need to know how to start service center in this section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not design section. when you start sc, you need run manual etcd .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i misunderstood how the package was made now. but it will be more user friendly to include the etcd in our binary package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TankTian There is no v1.3.x version in etcd release on github page, is there any misunderstood about the readme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry .misunderstood . it is should v3.x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TankTian Can you update the file for it?

@TankTian TankTian closed this May 31, 2017
ChinX pushed a commit to ChinX/servicecomb-service-center that referenced this pull request May 20, 2019
Decouple status of service-center to its plugin, run gofmt/goimports fot syncer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants