Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-2176 Refactor websocket (#986) #989

Merged
merged 3 commits into from
May 21, 2021
Merged

Conversation

little-cui
Copy link
Member

  • SCB-2176 Refactor event bus

  • SCB-2176 Fix: UT failures

  • SCB-2176 Refactor websocket (SCB-2176 Refactor websocket #980)

  • SCB-2176 Refactor websocket

  • SCB-2176 Add UTs

  • SCB-2176 Fix: UT failures

  • SCB-2176 Fix: websocket health check failed

  • SCB-2176 Add benchmark for 10K connection

  • SCB-2176 Add benchmark for 10K connection

  • SCB-2176 Add event metrics

(cherry picked from commit cc0f684)

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
  • Never comment source code, delete it.
  • UT should has "context, subject, expected result" result as test case name, when you call t.Run().

* SCB-2176 Refactor event bus

* SCB-2176 Fix: UT failures

* SCB-2176 Refactor websocket (apache#980)

* SCB-2176 Refactor websocket

* SCB-2176 Add UTs

* SCB-2176 Fix: UT failures

* SCB-2176 Fix: websocket health check failed

* SCB-2176 Add benchmark for 10K connection

* SCB-2176 Add benchmark for 10K connection

* SCB-2176 Add event metrics

(cherry picked from commit cc0f684)
server/event/instance_subscriber.go Outdated Show resolved Hide resolved
server/connection/ws/websocket.go Outdated Show resolved Hide resolved
@tianxiaoliang tianxiaoliang merged commit b5e162d into apache:v1.x May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants