Merge f003684 into c65b72f

apache · Nov 25, 2019 · a63db12 · a63db12
2 parents c65b72f + f003684
commit a63db12
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/...s-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/HttpStatuses.java b/...s-generator-core/src/main/java/org/apache/servicecomb/toolkit/generator/HttpStatuses.java
@@ -19,6 +19,9 @@
 
 public class HttpStatuses {
 
-  public static String OK = "200";
+  /**
+   *  HTTP/1.0 - RFC 1945
+   */
+  public final static String OK = "200";
 
 }
diff --git a/...rator-core/src/main/java/org/apache/servicecomb/toolkit/generator/context/OasContext.java b/...rator-core/src/main/java/org/apache/servicecomb/toolkit/generator/context/OasContext.java
@@ -75,7 +75,7 @@ public OpenAPI toOpenAPI() {
       pathItem.operation(HttpMethod.valueOf(operationCtx.getHttpMethod()), operationCtx.toOperation());
     }
 
-    // 如果没有restful资源则返回null
+    // return null if there is no restful resource
     if (openAPI.getPaths() == null || openAPI.getPaths().size() == 0) {
       return null;
     }

diff --git a/...core/src/main/java/org/apache/servicecomb/toolkit/generator/context/OperationContext.java b/...core/src/main/java/org/apache/servicecomb/toolkit/generator/context/OperationContext.java
@@ -107,7 +107,7 @@ public Operation toOperation() {
     Content content = new Content();
     MediaType mediaType = new MediaType();
 
-    // 处理参数
+    // process parameter
     List<Parameter> parameterList = parameterContexts.stream()
         .map(parameterContext ->
         {
@@ -164,8 +164,9 @@ public void correctResponse(ApiResponses apiResponses) {
     if (apiResponses == null) {
       return;
     }
-    // 处理响应
-    // 没有注解被处理
+
+    // no annotations are processed
+    // generate a default response based on the method return value
     if (apiResponses.get(HttpStatuses.OK) == null) {
       ApiResponse apiResponse = new ApiResponse();
 

diff --git a/...ain/java/org/apache/servicecomb/toolkit/generator/parser/api/OpenApiAnnotationParser.java b/...ain/java/org/apache/servicecomb/toolkit/generator/parser/api/OpenApiAnnotationParser.java
@@ -36,7 +36,8 @@ public interface OpenApiAnnotationParser {
   void parser(Class<?> cls, OasContext context);
 
   /**
-   * 用于排序, 对于同一个类，同时只能为springmvc或者jaxrs其中一种
+   * Used for sorting
+   * For the same parsing class, only the same programming model can be parsed at the same time.
    * @return
    */
   int getOrder();