Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCB-1351 Some issues about using toolkit plugin #6

Merged
merged 8 commits into from Jul 10, 2019

Conversation

MabinGo
Copy link
Contributor

@MabinGo MabinGo commented Jul 7, 2019

Signed-off-by: MabinGo bin.ma@huawei.com

fix bug about generating contract file

Signed-off-by: MabinGo <bin.ma@huawei.com>
fix bug about generating document

Signed-off-by: MabinGo <bin.ma@huawei.com>
add UT about generating document

Signed-off-by: MabinGo <bin.ma@huawei.com>
fix bug about verifying contract

Signed-off-by: MabinGo <bin.ma@huawei.com>
fix generating doc and UT

Signed-off-by: MabinGo <bin.ma@huawei.com>
@WillemJiang
Copy link
Member

Please add some description about the issue, it's hard for us the trace the issue without detail information.

@MabinGo
Copy link
Contributor Author

MabinGo commented Jul 8, 2019

I have written down the issues in Apache ServiceComb JIRA SCB-1351.
commit 6007961, fix the issue of invalid naming of generated contract files
commit fee7d12 and e306c9e,fix the issue of generating document failure
commit 2da7807,fix the issue of verifying contract file is not correct
commit 7e8c5bd,fix the issue of UT failure
commit 516660e,optimize toolkit user experience

@WillemJiang
Copy link
Member

I think we need to create a JIRA for each issue fixing from you description. It could help us generate a meaningful release note.

@MabinGo
Copy link
Contributor Author

MabinGo commented Jul 8, 2019

I have created JIRA(SCB-1358,SCB-1359,SCB-1360,SCB-1361) for each issues, and make SCB-1351 link to them.

Optimize the code according to user feedback and supplement UT

Signed-off-by: MabinGo <bin.ma@huawei.com>
@WillemJiang
Copy link
Member

There are three .class in the PR, we are not supposed to put binary file into source repository. If you want to do some Unit test on these compiled files, you can load the compiled file from target directory.

@MabinGo
Copy link
Contributor Author

MabinGo commented Jul 9, 2019

OK,the .class was removed,pls help to check again

Remove .class and compile source code to generate .class using the Runtime

Signed-off-by: MabinGo <bin.ma@huawei.com>
Signed-off-by: MabinGo <bin.ma@huawei.com>
@WillemJiang WillemJiang self-requested a review July 10, 2019 03:49
@WillemJiang WillemJiang merged commit c92635f into apache:master Jul 10, 2019
@MabinGo MabinGo deleted the codeOptandBugfix branch August 1, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants