avoid sync if get connection size is 1

apache · Sep 22, 2018 · 01b0361 · 01b0361
1 parent d99231a
commit 01b0361
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/...ing-jdbc/src/main/java/io/shardingsphere/core/jdbc/adapter/AbstractConnectionAdapter.java b/...ing-jdbc/src/main/java/io/shardingsphere/core/jdbc/adapter/AbstractConnectionAdapter.java
@@ -48,6 +48,7 @@
 import java.sql.SQLWarning;
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 
@@ -120,16 +121,23 @@ public final List<Connection> getConnections(final String dataSourceName, final
     @SuppressWarnings("SynchronizationOnLocalVariableOrMethodParameter")
     private List<Connection> createConnections(final DataSource dataSource, final int connectionSize) throws SQLException {
         List<Connection> result = new ArrayList<>(connectionSize);
+        if (1 == connectionSize) {
+            return Collections.singletonList(createConnection(dataSource));
+        }
         synchronized (dataSource) {
             for (int i = 0; i < connectionSize; i++) {
-                Connection connection = dataSource.getConnection();
-                replayMethodsInvocation(connection);
-                result.add(connection);
+                result.add(createConnection(dataSource));
             }
         }
         return result;
     }
 
+    private Connection createConnection(final DataSource dataSource) throws SQLException {
+        Connection result = dataSource.getConnection();
+        replayMethodsInvocation(result);
+        return result;
+    }
+
     private void postGetConnectionEvent(final List<Connection> connections) throws SQLException {
         GetConnectionEvent finishEvent = new GetConnectionFinishEvent(connections.size(), DataSourceMetaDataFactory.newInstance(databaseType, connections.get(0).getMetaData().getURL()));
         finishEvent.setExecuteSuccess();

diff --git a/.../src/main/java/io/shardingsphere/proxy/backend/jdbc/datasource/JDBCBackendDataSource.java b/.../src/main/java/io/shardingsphere/proxy/backend/jdbc/datasource/JDBCBackendDataSource.java
@@ -31,6 +31,7 @@
 import java.sql.Connection;
 import java.sql.SQLException;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
@@ -108,6 +109,9 @@ public Connection getConnection(final String dataSourceName) throws SQLException
     public List<Connection> getConnections(final String dataSourceName, final int connectionSize) throws SQLException {
         List<Connection> result = new ArrayList<>(connectionSize);
         DataSource dataSource = getDataSourceMap().get(dataSourceName);
+        if (1 == connectionSize) {
+            return Collections.singletonList(dataSource.getConnection());
+        }
         synchronized (dataSource) {
             for (int i = 0; i < connectionSize; i++) {
                 result.add(dataSource.getConnection());