Skip to content

Commit

Permalink
1. rename ConfigurationPrinter.printConfiguration() to ConfigurationL…
Browse files Browse the repository at this point in the history
…ogger.log()

2. move configuration log statement from XXXRule to XXXDataBase for JDBC
3. move configuration log statement from XXXRule to Bootstrap and XXXSchema's renew() for Proxy
  • Loading branch information
sunbufu committed Jul 14, 2019
1 parent 5308ebe commit d5113f0
Show file tree
Hide file tree
Showing 31 changed files with 396 additions and 312 deletions.
Expand Up @@ -20,7 +20,6 @@
import lombok.Getter;
import org.apache.shardingsphere.api.config.encryptor.EncryptRuleConfiguration;
import org.apache.shardingsphere.core.strategy.encrypt.ShardingEncryptorEngine;
import org.apache.shardingsphere.core.util.ConfigurationPrinter;

import java.util.Collection;

Expand All @@ -43,10 +42,8 @@ public EncryptRule() {
public EncryptRule(final EncryptRuleConfiguration encryptRuleConfiguration) {
this.encryptRuleConfig = encryptRuleConfiguration;
encryptorEngine = new ShardingEncryptorEngine(encryptRuleConfiguration);

ConfigurationPrinter.printConfiguration("encryptRule", encryptRuleConfiguration);
}

/**
* Get encrypt table names.
*
Expand Down
Expand Up @@ -21,7 +21,6 @@
import org.apache.shardingsphere.api.config.masterslave.LoadBalanceStrategyConfiguration;
import org.apache.shardingsphere.api.config.masterslave.MasterSlaveRuleConfiguration;
import org.apache.shardingsphere.core.spi.algorithm.masterslave.MasterSlaveLoadBalanceAlgorithmServiceLoader;
import org.apache.shardingsphere.core.util.ConfigurationPrinter;
import org.apache.shardingsphere.spi.masterslave.MasterSlaveLoadBalanceAlgorithm;

import java.util.Collection;
Expand Down Expand Up @@ -52,8 +51,6 @@ public MasterSlaveRule(final String name, final String masterDataSourceName, fin
this.loadBalanceAlgorithm = null == loadBalanceAlgorithm ? new MasterSlaveLoadBalanceAlgorithmServiceLoader().newService() : loadBalanceAlgorithm;
masterSlaveRuleConfiguration = new MasterSlaveRuleConfiguration(name, masterDataSourceName, slaveDataSourceNames,
new LoadBalanceStrategyConfiguration(this.loadBalanceAlgorithm.getType(), this.loadBalanceAlgorithm.getProperties()));

ConfigurationPrinter.printConfiguration("masterSlaveRule", masterSlaveRuleConfiguration);
}

public MasterSlaveRule(final MasterSlaveRuleConfiguration config) {
Expand All @@ -62,8 +59,6 @@ public MasterSlaveRule(final MasterSlaveRuleConfiguration config) {
slaveDataSourceNames = config.getSlaveDataSourceNames();
loadBalanceAlgorithm = createMasterSlaveLoadBalanceAlgorithm(config.getLoadBalanceStrategyConfiguration());
masterSlaveRuleConfiguration = config;

ConfigurationPrinter.printConfiguration("masterSlaveRule", config);
}

private MasterSlaveLoadBalanceAlgorithm createMasterSlaveLoadBalanceAlgorithm(final LoadBalanceStrategyConfiguration loadBalanceStrategyConfiguration) {
Expand Down
Expand Up @@ -34,7 +34,6 @@
import org.apache.shardingsphere.core.strategy.route.ShardingStrategyFactory;
import org.apache.shardingsphere.core.strategy.route.hint.HintShardingStrategy;
import org.apache.shardingsphere.core.strategy.route.none.NoneShardingStrategy;
import org.apache.shardingsphere.core.util.ConfigurationPrinter;
import org.apache.shardingsphere.spi.keygen.ShardingKeyGenerator;

import java.util.ArrayList;
Expand Down Expand Up @@ -86,8 +85,6 @@ public ShardingRule(final ShardingRuleConfiguration shardingRuleConfig, final Co
defaultShardingKeyGenerator = createDefaultKeyGenerator(shardingRuleConfig.getDefaultKeyGeneratorConfig());
masterSlaveRules = createMasterSlaveRules(shardingRuleConfig.getMasterSlaveRuleConfigs());
encryptRule = createEncryptRule(shardingRuleConfig.getEncryptRuleConfig());

ConfigurationPrinter.printConfiguration("shardingRule", shardingRuleConfig);
}

private Collection<TableRule> createTableRules(final ShardingRuleConfiguration shardingRuleConfig) {
Expand Down
@@ -0,0 +1,127 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE
* file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file
* to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the
* License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/

package org.apache.shardingsphere.core.util;

import java.util.Properties;

import org.apache.shardingsphere.api.config.RuleConfiguration;
import org.apache.shardingsphere.api.config.encryptor.EncryptRuleConfiguration;
import org.apache.shardingsphere.api.config.masterslave.MasterSlaveRuleConfiguration;
import org.apache.shardingsphere.api.config.sharding.ShardingRuleConfiguration;
import org.apache.shardingsphere.core.rule.Authentication;
import org.apache.shardingsphere.core.yaml.engine.YamlEngine;
import org.apache.shardingsphere.core.yaml.swapper.impl.AuthenticationYamlSwapper;
import org.apache.shardingsphere.core.yaml.swapper.impl.EncryptRuleConfigurationYamlSwapper;
import org.apache.shardingsphere.core.yaml.swapper.impl.MasterSlaveRuleConfigurationYamlSwapper;
import org.apache.shardingsphere.core.yaml.swapper.impl.ShardingRuleConfigurationYamlSwapper;

import lombok.extern.slf4j.Slf4j;

/**
* Configuration printer class.
*
* @author sunbufu
*/
@Slf4j
public final class ConfigurationLogger {

private ConfigurationLogger() { }

/**
* log properties configuration.
*
* @param propsConfiguration properties configuration
*/
public static void log(final Properties propsConfiguration) {
if (null != propsConfiguration) {
log(propsConfiguration.getClass().getSimpleName(), YamlEngine.marshal(propsConfiguration));
}
}

/**
* log EncryptRuleConfiguration.
*
* @param encryptRuleConfiguration encryptRule configuration
*/
public static void log(final EncryptRuleConfiguration encryptRuleConfiguration) {
if (null != encryptRuleConfiguration) {
log(encryptRuleConfiguration.getClass().getSimpleName(),
YamlEngine.marshal(new EncryptRuleConfigurationYamlSwapper().swap(encryptRuleConfiguration)));
}
}

/**
* log ruleConfiguration.
*
* @param ruleConfiguration ruleConfiguration
*/
public static void log(final RuleConfiguration ruleConfiguration) {
if (null != ruleConfiguration) {
if (ruleConfiguration instanceof ShardingRuleConfiguration) {
ConfigurationLogger.log((ShardingRuleConfiguration) ruleConfiguration);
} else if (ruleConfiguration instanceof MasterSlaveRuleConfiguration) {
ConfigurationLogger.log((MasterSlaveRuleConfiguration) ruleConfiguration);
} else if (ruleConfiguration instanceof EncryptRuleConfiguration) {
ConfigurationLogger.log((EncryptRuleConfiguration) ruleConfiguration);
}
}
}

/**
* log ShardingRuleConfiguration.
*
* @param shardingRuleConfiguration shardingRule configuration
*/
public static void log(final ShardingRuleConfiguration shardingRuleConfiguration) {
if (null != shardingRuleConfiguration) {
log(shardingRuleConfiguration.getClass().getSimpleName(),
YamlEngine.marshal(new ShardingRuleConfigurationYamlSwapper().swap(shardingRuleConfiguration)));
}
}

/**
* log MasterSlaveRuleConfiguration.
*
* @param masterSlaveRuleConfiguration masterSlaveRule configuration
*/
public static void log(final MasterSlaveRuleConfiguration masterSlaveRuleConfiguration) {
if (null != masterSlaveRuleConfiguration) {
log(masterSlaveRuleConfiguration.getClass().getSimpleName(),
YamlEngine.marshal(new MasterSlaveRuleConfigurationYamlSwapper().swap(masterSlaveRuleConfiguration)));
}
}

/**
* log AuthenticationConfiguration.
*
* @param authenticationConfiguration authentication configuration
*/
public static void log(final Authentication authenticationConfiguration) {
if (null != authenticationConfiguration) {
log(authenticationConfiguration.getClass().getSimpleName(),
YamlEngine.marshal(new AuthenticationYamlSwapper().swap(authenticationConfiguration)));
}
}

/**
* log configuration log.
*
* @param base base node name
* @param yamlStr yaml string
*/
public static void log(final String base, final String yamlStr) {
log.info("{}\n{}", base, yamlStr);
}

}

This file was deleted.

0 comments on commit d5113f0

Please sign in to comment.