New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API Change] Move the user configuration to authority rule #10251
Comments
Hi guys, @huanghao495430759 @zhujunxxxxx Hope you have an enjoyable holiday! I have to say there are two important and challenging issues to seek excellent contributors from the community. I just wonder whether you are interested in this issue and #10252 and willing to take charge? Here are some pointers FYI,
If you are not available, please still tell me so that I can assign these issues to others. Thanks. |
OK锛孡et me try. |
Hi @zhujunxxxxx , |
OK, Can I try it too ? |
I want to try #10251. |
@zhujunxxxxx Hey, welcome. |
Hi, community,
This issue is to do API change of
server.yaml
of ShardingProxy. More precisely to say, we plan to move theuser
configuration to theauthority
rule module. Hope you can have a try and get 馃憤 .Target
Please change the configuration of
server.yaml
fromTO
How?
There are two necessary sections to achieve it.
The refactoring of Yaml configuration
1 Move
users
fromYamlProxyServerConfiguration
toYamlAuthorityRuleConfiguration
2 Move
YamlUsersConfigurationConverter
handling fromYamlProxyConfigurationSwapper
toAuthorityRuleConfigurationYamlSwapper
3 Move
users
fromProxyConfiguration
toAuthorityRuleConfiguration
4 Remove
persistUsers(users, isOverwrite);
ofRegistryCenter
5 Move the relevant Unit test classes to corresponding packages.
The change of User and authority initialization
1 Remove
users
, which has been stored inAuthorityRuleConfiguration
fromMetaDataContextsBuilder
2 Remove
users
from the signature ofShardingSphereRulesBuilder.buildGlobalRules()
3 Put
users
intoAuthorityRule
fromAuthorityRuleConfiguration
4 Fix the Unit tests
The text was updated successfully, but these errors were encountered: