Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more test cases for XAConnectionWrapperFactoryTest #17586

Closed
Tracked by #17537
terrymanu opened this issue May 11, 2022 · 1 comment
Closed
Tracked by #17537

Add more test cases for XAConnectionWrapperFactoryTest #17586

terrymanu opened this issue May 11, 2022 · 1 comment
Labels
in: test
Milestone
5.2.0

Comments

@terrymanu
Copy link
Member

terrymanu commented May 11, 2022 •
edited
Loading

This issue is for WeOpen-Star

The steps of add test case of SPI factories:

  1. Create or reuse a SPI fixture, name as XXXFixture in test folder and do not forget put them into META-INF/services;
  2. Add test case for XXXFactory's newInstance, findInstance, getInstance, getInstances, getAllInstances and so on;
    3.Please reference ClusterPersistRepositoryFactoryTest or ScalingEntryFactoryTest as samples.
@terrymanu terrymanu mentioned this issue May 11, 2022
Closed
43 tasks
@QUBOHAO1998 QUBOHAO1998 mentioned this issue May 13, 2022
Open
@kaori-seasons
Copy link
Contributor

kaori-seasons commented May 23, 2022 •
edited
Loading

I would like to help

kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
74bb385 
add unit tests for DialectDDLGeneratorFactoryTest
@kaori-seasons kaori-seasons mentioned this issue May 24, 2022
Merged
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
4422e62 
fix checkstyle
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
d994bfe 
remove whitespace
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
9e67d50 
refactor DialectDDLGeneratorFixTrue
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
b495f7b 
export SPI
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
b6ab701 
Add more test cases for XAConnectionWrapperFactoryTest
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
1d0922d 
exported SPI
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
333d551 
Add more test cases for XAConnectionWrapperFactoryTest
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
ba471d2 
exported SPI
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 24, 2022
@kaori-seasons
[issue-17586](apache#17586)
c873d6f 
remove local changes
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 25, 2022
@kaori-seasons
[issue-17586](apache#17586)
31d9385 
fix checkstyle
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 25, 2022
@kaori-seasons
[issue-17586](apache#17586)
a5b9b33 
fix checkstyle
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 26, 2022
@kaori-seasons
[issue-17586](apache#17586)
1425620 
add unit tests for DialectDDLGeneratorFactoryTest
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 26, 2022
@kaori-seasons
[issue-17586](apache#17586)
1b996cc 
fix checkstyle
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 26, 2022
@kaori-seasons
[issue-17586](apache#17586)
a566fab 
remove whitespace
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 26, 2022
@kaori-seasons
[issue-17586](apache#17586)
b3416d6 
refactor DialectDDLGeneratorFixTrue
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 26, 2022
@kaori-seasons
[issue-17586](apache#17586)
20f11b4 
export SPI
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue May 26, 2022
@kaori-seasons
[issue-17586](apache#17586)
8ef77ee 
fix checkstyle
terrymanu pushed a commit that referenced this issue May 28, 2022
@kaori-seasons
add unit tests for DialectDDLGeneratorFactoryTest (#17910)
a7d5dc6 
* [issue-17586](#17586)
add unit tests for DialectDDLGeneratorFactoryTest

* [issue-17586](#17586)
fix checkstyle

* [issue-17586](#17586)
remove whitespace

* [issue-17586](#17586)
refactor DialectDDLGeneratorFixTrue

* [issue-17586](#17586)
export SPI

* [issue-17586](#17586)
fix checkstyle

* [issue-17552](#17552)
fix bugs

* [issue-17552](#17555)
remove fields

* [issue-17555](#17555)
remove fields

* [issue-17555](#17555)
add license and remove whitespace

* [issue-17555](#17555)
add license

* [issue-17555](#17555)
fix ci

* [issue-17555](#17555)
fix ci

* [issue-17555](#17555)
fix ci

* [issue-17555](#17555)
repair review comment

* [issue-17555](#17555)
repair review comment

* [issue-17555](#17555)
repair review comment

* [issue-17555](#17555)
fix checkstyle

* [issue-17555](#17555)
add maven scope
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue Jun 2, 2022
@kaori-seasons
[issue-17586](apache#17586)
92967f3 
Add more test cases for XAConnectionWrapperFactoryTest
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue Jun 2, 2022
@kaori-seasons
[issue-17586](apache#17586)
5fd0988 
exported SPI
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue Jun 2, 2022
@kaori-seasons
[issue-17586](apache#17586)
12df061 
remove local changes

upstream merge
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue Jun 2, 2022
@kaori-seasons
[issue-17586](apache#17586)
acb8926 
Add more test cases for XAConnectionWrapperFactoryTest

upstream master
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue Jun 2, 2022
@kaori-seasons
[issue-17586](apache#17586)
99ce9bb 
Add more test cases for XAConnectionWrapperFactoryTest

merge upstream
kaori-seasons added a commit to kaori-seasons/shardingsphere that referenced this issue Jun 2, 2022
@kaori-seasons
[issue-17586](apache#17586)
f027f89 
Add more test cases for XAConnectionWrapperFactoryTest

cherry-pick
@terrymanu terrymanu mentioned this issue Jun 21, 2022
Merged
@terrymanu terrymanu added this to the 5.1.3 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
2 participants
@terrymanu @kaori-seasons