the latest 4.0.x version of the configuration MasterSlaveRuleConfiguration properly

[lonyee1989]

The latest 4.0.x version of the configuration MasterSlaveRuleConfiguration properly

The hard solution by lonyee
https://www.jianshu.com/p/30175084c918

It is best to modify the write related config class.

[lonyee1989]

for #2846 4.0.x version of the configuration MasterSlaveRuleConfiguration properly

[terrymanu]

We should update document later, but a full parameters' constructor is necessary.

I will open a new issue on document repo

[lonyee1989]

OK... I think custom yaml configuration should be supported, and does configuration validation work in the official yaml without parametric constructors?

like this? @terrymanu

masterSlaveRules:
      ms_ds0:
        masterDataSourceName: ds0
        slaveDataSourceNames:
          - ds0_slave0
          - ds0_slave1
        loadBalanceAlgorithmType: ROUND_ROBIN
      ms_ds1:
        masterDataSourceName: ds1
        slaveDataSourceNames: 
          - ds1_slave0
          - ds1_slave1
        loadBalanceAlgorithmType: ROUND_ROBIN

[tristaZero]

Hi, @lonyee1989 Thanks for your issue , can you fix this problem and raise a pr for Sharding Sphere document? Thanks a lot

[lonyee1989]

@tristaZero ok, I'll try it.

[tristaZero]

Hi，we plan to release new version tomorrow, so can you fix this bug today or tomorrow?:)
@lonyee1989

[tristaZero]

Hi，we plan to release new version tomorrow, so can you fix this bug today or tomorrow?:)
@lonyee1989

[tristaZero]

Hi，we plan to release new version tomorrow, so can you fix this bug today or tomorrow?:)
@lonyee1989

[lonyee1989]

I'm going to do it tomorrow and try to finish it within this week. @tristaZero

[tristaZero]

Thanks for your comprehension, please raise pr to doc.
@lonyee1989 (ﾟ▽ﾟ)/

[lonyee1989]

@tristaZero I have submitted the update of the document. shardingsphere-doc#224

[tristaZero]

@lonyee1989 Hi, you checked and changed a lot of content of document, thinks a lot.
But actually, we change the api and document of encryption in the latest verssion i.e, 4.0.0.RC2 , so the description of encryption in document is right.
Can you delete the changes of encryption in your pr and just keep the changes about masterSlaveConfig?
What's more, masterSlaveConfig is used a lot in document, can you find them and change them togather?
Thanks a lot, our new version needs your contribution :).

[lonyee1989]

@tristaZero aha, I have fixed it. shardingsphere-doc#227
:) waiting for the version 4.0.0.RC2

[tristaZero]

@lonyee1989 merged it , good job! 4.0.0.RC2 is coming soon. Thanks for your contribution:)