Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove renew() from AbstractDataSourceAdapter #1214

Merged
merged 15 commits into from Aug 31, 2018
Merged

Remove renew() from AbstractDataSourceAdapter #1214

merged 15 commits into from Aug 31, 2018

Conversation

tristaZero
Copy link
Contributor

Changes proposed in this pull request:

  • Remove renew() from AbstractDataSourceAdapter
  • Check style

@terrymanu terrymanu merged commit d9cfe3c into apache:dev Aug 31, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4927

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 64.294%

Files with Coverage Reduction New Missed Lines %
sharding-orchestration/sharding-orchestration-reg/src/main/java/io/shardingsphere/orchestration/reg/newzk/client/zookeeper/base/Holder.java 1 76.81%
sharding-orchestration/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-namespace/src/main/java/io/shardingsphere/jdbc/orchestration/spring/datasource/OrchestrationShardingDataSourceFactoryBean.java 1 66.67%
Totals Coverage Status
Change from base Build 4926: 0.05%
Covered Lines: 8236
Relevant Lines: 12810

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants