Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when has complex expression on sharding column #1222

Merged
merged 4 commits into from Sep 2, 2018
Merged

fix bug when has complex expression on sharding column #1222

merged 4 commits into from Sep 2, 2018

Conversation

maxiaoguang64
Copy link
Collaborator

fix 1045

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4959

  • 25 of 31 (80.65%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 63.951%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/src/main/java/io/shardingsphere/core/parsing/parser/clause/WhereClauseParser.java 23 29 79.31%
Files with Coverage Reduction New Missed Lines %
sharding-core/src/main/java/io/shardingsphere/core/parsing/parser/clause/InsertDuplicateKeyUpdateClauseParser.java 2 86.96%
Totals Coverage Status
Change from base Build 4958: -0.003%
Covered Lines: 7944
Relevant Lines: 12422

💛 - Coveralls

@terrymanu terrymanu merged commit 9710dda into apache:dev Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are some problems when the expression is parsed
3 participants