Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoupling JDBCBackendConnection from ConnectionSession #13975

Merged
merged 16 commits into from Dec 7, 2021
Merged

Decoupling JDBCBackendConnection from ConnectionSession #13975

merged 16 commits into from Dec 7, 2021

Conversation

TeslaCN
Copy link
Member

@TeslaCN TeslaCN commented Dec 7, 2021 •
edited

Related to #13957

Changes proposed in this pull request:

  • Make abstract class ConnectionSession to final and use it in proxy as possible
  • Rename JDBCConnectionSession to JDBCBackendConnection and extract BackendConnection from it
  • JDBCBackendConnection implements BackendConnection
  • Decoupling JDBCBackendConnection from CommandExecutorTask and push down logic of closing resources to JDBCBackendConnection

@TeslaCN
Extract BackendConnection from ConnectionSession
8ccb8a3
@TeslaCN
Fix tests in proxy-frontend-core
1b15e19
@TeslaCN
Fix tests in proxy-backend
dcc6843
@TeslaCN
Fix tests in proxy-frontend-mysql
2cdfdf0
@TeslaCN
Fix tests in proxy-frontend-postgresql
cfe5e20
@TeslaCN
Rename variables
5afab02
@TeslaCN
Merge branch 'master' into 13957_extract_backend_connection
cef1239 
# Conflicts:
#	shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/admin/mysql/executor/information/SelectInformationExecutorTest.java
@TeslaCN
Merge updates from master
1f35948
@TeslaCN
Fix rat and checkstyle
9caa933
@TeslaCN
Decouple JDBCBackendConnection from TextProtocolBackendHandlerFactory
ddf292d
@TeslaCN
Minor refactor CommandExecutorTask
fb36511
@TeslaCN
Rename descriptions in javadoc
36a647b
@TeslaCN
Add javadoc for BackendConnection
e68ac55
@TeslaCN
Move TransactionStatus to session package
b6b82c1
@TeslaCN
Fix agents
c72aad5
@TeslaCN
Decoupling JDBCBackendConnection from CommandExecutorTask
ea2f65b
@TeslaCN TeslaCN added this to the 5.0.1 milestone Dec 7, 2021
@TeslaCN TeslaCN marked this pull request as ready for review December 7, 2021 10:58
@tristaZero tristaZero merged commit baa9eda into apache:master Dec 7, 2021
TeslaCN added a commit to TeslaCN/shardingsphere that referenced this pull request Dec 7, 2021
@TeslaCN
Revise apache#13975 and add more tests
d92bff7
@TeslaCN TeslaCN mentioned this pull request Dec 7, 2021
Merged
sandynz pushed a commit that referenced this pull request Dec 7, 2021
@TeslaCN
Revise #13975 and add more tests (#13985)
3aeff7f 
* Revise #13975 and add more tests

* Catch BackendConnectionException and log

* Rename test case

* Add connection id to log error message
@TeslaCN TeslaCN deleted the 13957_extract_backend_connection branch December 8, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristaZero tristaZero tristaZero approved these changes

@terrymanu terrymanu Awaiting requested review from terrymanu

Assignees
No one assigned
Labels
in: proxy type: refactor
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TeslaCN @tristaZero