Add CosIdKeyGenerateAlgorithm / CosIdIntervalShardingAlgorithm /CosIdModShardingAlgorithm
#14132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `CosIdIntervalShardingAlgorithm` - add `CosIdModShardingAlgorithm`
…-dd HH:mm:ss` (`CosIdIntervalShardingAlgorithm`).
Codecov Report
@@ Coverage Diff @@
## master #14132 +/- ##
============================================
- Coverage 63.64% 60.88% -2.76%
+ Complexity 1843 1766 -77
============================================
Files 2865 2858 -7
Lines 42737 42502 -235
Branches 7269 7250 -19
============================================
- Hits 27198 25878 -1320
- Misses 13453 14625 +1172
+ Partials 2086 1999 -87
Continue to review full report at Codecov.
|
menghaoranss
requested changes
Dec 17, 2021
...main/java/org/apache/shardingsphere/sharding/algorithm/keygen/CosIdKeyGenerateAlgorithm.java
Outdated
Show resolved
Hide resolved
| */ | ||
| public final class CosIdIntervalShardingAlgorithm implements StandardShardingAlgorithm<Comparable<?>> { | ||
|
|
||
| public static final String TYPE = CosIdAlgorithm.TYPE_PREFIX + "INTERVAL"; |
There was a problem hiding this comment.
Please confirm whether all variables need public
.../apache/shardingsphere/sharding/algorithm/sharding/cosid/CosIdIntervalShardingAlgorithm.java
Outdated
Show resolved
Hide resolved
.../apache/shardingsphere/sharding/algorithm/sharding/cosid/CosIdIntervalShardingAlgorithm.java
Outdated
Show resolved
Hide resolved
.../apache/shardingsphere/sharding/algorithm/sharding/cosid/CosIdIntervalShardingAlgorithm.java
Outdated
Show resolved
Hide resolved
...a/org/apache/shardingsphere/sharding/algorithm/sharding/cosid/CosIdModShardingAlgorithm.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/shardingsphere/sharding/algorithm/keygen/CosIdKeyGenerateAlgorithmTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| public static class LocalDateTimePreciseValueDoShardingTest { |
There was a problem hiding this comment.
could these test methods be split into test classes?
...g/apache/shardingsphere/sharding/algorithm/sharding/cosid/CosIdModShardingAlgorithmTest.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * CosId key generate algorithm. | ||
| */ | ||
| public final class CosIdKeyGenerateAlgorithm implements KeyGenerateAlgorithm { |
There was a problem hiding this comment.
I want to know how it works in the cluster mode.
strongduanmu
requested changes
Dec 17, 2021
...main/java/org/apache/shardingsphere/sharding/algorithm/keygen/CosIdKeyGenerateAlgorithm.java
Outdated
Show resolved
Hide resolved
...a/org/apache/shardingsphere/sharding/algorithm/sharding/cosid/CosIdModShardingAlgorithm.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/cosid/PropertiesUtil.java
Outdated
Show resolved
Hide resolved
.../apache/shardingsphere/sharding/algorithm/sharding/cosid/CosIdIntervalShardingAlgorithm.java
Outdated
Show resolved
Hide resolved
strongduanmu
requested changes
Dec 22, 2021
| IntervalTimeline intervalTimeline = new IntervalTimeline(logicNamePrefix, Range.closed(effectiveLower, effectiveUpper), IntervalStep.of(stepUnit, stepAmount), suffixFormatter); | ||
| boolean isSecondTs = getProps().containsKey(TIMESTAMP_TYPE_KEY) | ||
| && TIMESTAMP_SECOND_TYPE.equalsIgnoreCase(getProps().getProperty(TIMESTAMP_TYPE_KEY)); | ||
| final String dateTimePattern = getProps().getProperty(DATE_TIME_PATTERN_KEY, DEFAULT_DATE_TIME_PATTERN); |
There was a problem hiding this comment.
@Ahoo-Wang Please remove this final modifier.
strongduanmu
approved these changes
Dec 22, 2021
menghaoranss
approved these changes
Dec 22, 2021
TeslaCN
reviewed
Dec 22, 2021
@TeslaCN I will follow up. |
@TeslaCN @menghaoranss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14047 .
Changes proposed in this pull request:
CosIdKeyGenerateAlgorithmCosIdIntervalShardingAlgorithmCosIdModShardingAlgorithmhttps://github.com/Ahoo-Wang/CosId#shardingsphere-plugin
This pull request does not include (I will finish the rest of the issue in the next time.):