Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 1348 #1499

Merged
merged 4 commits into from
Nov 20, 2018
Merged

fix 1348 #1499

merged 4 commits into from
Nov 20, 2018

Conversation

loxp
Copy link
Contributor

@loxp loxp commented Nov 20, 2018

Fixes #1348

Changes proposed in this pull request:

@loxp loxp changed the title fix #1348 fix 1348 Nov 20, 2018
@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 5706

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.4%) to 71.063%

Files with Coverage Reduction New Missed Lines %
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/extractor/statement/handler/filler/TableJoinHandlerResultFiller.java 1 40.0%
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/extractor/statement/handler/filler/ColumnDefinitionHandlerResultFiller.java 1 96.88%
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/extractor/statement/handler/filler/AbstractHandlerResultFiller.java 2 71.43%
sharding-core/src/main/java/io/shardingsphere/core/parsing/antlr/sql/ddl/AlterTableStatement.java 3 73.68%
Totals Coverage Status
Change from base Build 5701: 0.4%
Covered Lines: 8836
Relevant Lines: 12434

💛 - Coveralls

@terrymanu terrymanu merged commit bd05896 into apache:dev Nov 20, 2018
@loxp loxp deleted the fix-1348 branch November 21, 2018 01:10
@terrymanu terrymanu added this to the 3.1.0.M1 milestone Dec 12, 2018
@scuwuyu scuwuyu mentioned this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants