Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for DataNodeBuilderFactory #17695

Merged
merged 1 commit into from
May 16, 2022
Merged

add test for DataNodeBuilderFactory #17695

merged 1 commit into from
May 16, 2022

Conversation

csonezp
Copy link
Contributor

@csonezp csonezp commented May 16, 2022

Fixes #17581 .

Changes proposed in this pull request:

  • add test for DataNodeBuilderFactory

@codecov-commenter
Copy link

Codecov Report

Merging #17695 (3664c61) into master (74b1d27) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #17695      +/-   ##
============================================
- Coverage     58.81%   58.80%   -0.01%     
- Complexity     2125     2126       +1     
============================================
  Files          3596     3599       +3     
  Lines         53537    53571      +34     
  Branches       9143     9146       +3     
============================================
+ Hits          31487    31504      +17     
- Misses        19376    19393      +17     
  Partials       2674     2674              
Impacted Files Coverage Δ
...uery/ShowScalingCheckAlgorithmsQueryResultSet.java 77.77% <0.00%> (-8.89%) ⬇️
...ode/repository/standalone/file/FileRepository.java 58.53% <0.00%> (-0.99%) ⬇️
...end/text/distsql/ral/RALBackendHandlerFactory.java 88.23% <0.00%> (-0.86%) ⬇️
...jdbc/core/datasource/ShardingSphereDataSource.java 94.59% <0.00%> (-0.15%) ⬇️
...shardingsphere/infra/instance/InstanceContext.java 34.28% <0.00%> (ø)
...ardingsphere/infra/properties/TypedProperties.java 94.44% <0.00%> (ø)
...ngsphere/infra/properties/PropertiesConverter.java 100.00% <0.00%> (ø)
...de/metadata/persist/node/DatabaseMetaDataNode.java 71.87% <0.00%> (ø)
...ken/pojo/generic/UseDefaultInsertColumnsToken.java 100.00% <0.00%> (ø)
...tsql/ral/common/queryable/ShowInstanceHandler.java 0.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b1d27...3664c61. Read the comment docs.

@terrymanu terrymanu merged commit 28c6565 into apache:master May 16, 2022
@terrymanu terrymanu added this to the 5.1.2 milestone May 16, 2022
@terrymanu terrymanu mentioned this pull request May 16, 2022
tristaZero pushed a commit that referenced this pull request May 16, 2022
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this pull request May 17, 2022
* master: (90 commits)
  Remove usage of com.google.common.collect.Collections2 (apache#17721)
  Refactor execute RAL  statement reload metaData (apache#17720)
  Use caffeine instead of guava cache (apache#17712)
  Minor changes for test cases and code format (apache#17718)
  Add test case for RuleBasedSchemaMetaDataBuilderFactory . (apache#17709)
  Update Mockito and ByteBuddy to help with GraalVM integration (apache#17665)
  fix CI error (apache#17713)
  Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit)  apache#16091 (apache#17714)
  Remove useless DatabaseMetaDataContextsBuilder (apache#17717)
  private MetaDataContextsBuilder.addDatabase and addSystemDatabases (apache#17716)
  Add unit test for ModShardingAlgorithm  (apache#17710)
  Refactor distribute database lock (apache#17711)
  Add unit test for Bootstrap use proxy default port from props (apache#17707)
  Scaling IT optimization (apache#17702)
  Add test cases for SQLRewriteContextDecoratorFactory and ExecutionPrepareDecoratorFactory . (apache#17701)
  Use ConfigurationProperties in ContextManager (apache#17706)
  Use ConfigurationProperties in MetaDataContextsBuilder (apache#17705)
  Refactor create schema statement parse logic (apache#17703)
  Revise apache#17695 (apache#17700)
  add test for DataNodeBuilderFactory (apache#17695)
  ...
galaxylqx added a commit to galaxylqx/shardingsphere that referenced this pull request May 18, 2022
galaxylqx added a commit to galaxylqx/shardingsphere that referenced this pull request May 19, 2022
galaxylqx added a commit to galaxylqx/shardingsphere that referenced this pull request May 19, 2022
strongduanmu pushed a commit that referenced this pull request May 19, 2022
* Add unit test for ModShardingAlgorithm check Argument(#17695)

* Fix CI ERROR (#17695)

* Fix CI ERROR (#17695)
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this pull request May 19, 2022
* master:
  Fix the exception when specifying schema when JDBC connects to Proxy (apache#17611)
  Add ProxyContextRestorer to restore proxy context in test cases (apache#17802)
  Remove redundant blank chars and lines in codes (apache#17799)
  Supports scaling MySQL table which only contains unique index (apache#17786)
  Add unit test for ModShardingAlgorithm check Argument(apache#17695) (apache#17772)
  Move getSchemas method to ShardingSphereDatabase (apache#17798)
  Fix unit tests in proxy-frontend-core affected by other tests (apache#17796)
  Update powered by (apache#17795)
  Add support for more JSR-310 related classes about JDBC Timestamp in IntervalShardingAlgorithm (apache#17754)
  Rename ShardingSphereMetaData to ShardingSphereDatabaseMetaData (apache#17792)
  Rename MetaDataContexts.persistService (apache#17789)
  Move ContextManager.executorEngine (apache#17783)
  Change proxy log print at Docker images, get more information (apache#17788)
  fix datasource closed exception for db-discovery (apache#17774)
  Add lock method for schema in lock manager (apache#17787)
  Refactor MetaDataChangedWatcher (apache#17781)
  Refactor PipelineTableMetaDataLoader and fix typo in PipelineTableMetaData (apache#17778)
  Rename DatabaseRulesBuilder (apache#17780)

# Conflicts:
#	shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/test/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptAlgorithmMetaDataTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case for DataNodeBuilderFactory
3 participants