Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test cases for WeOpen-Star . #18059

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Conversation

misselvexu
Copy link
Contributor

@misselvexu misselvexu commented May 30, 2022

Fixes #17574 .
Fixes #17573 .
Fixes #17572 .
Fixes #17571 .
Fixes #17570 .
Fixes #17569 .
Fixes #17568 .
Fixes #17567 .
Fixes #17566 .
Fixes #17565 .
Fixes #17564 .
Fixes #17563 .
Fixes #17562 .
Fixes #17561 .
Fixes #17560 .
Fixes #17557 .
Fixes #17556 .
Fixes #17554 .
Fixes #17553 .
Fixes #17550 .
Fixes #17549 .
Fixes #17548 .
Fixes #17540 .

Changes proposed in this pull request:

@codecov-commenter
Copy link

Codecov Report

Merging #18059 (06f9381) into master (0f8ffc3) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #18059      +/-   ##
============================================
+ Coverage     58.95%   59.01%   +0.05%     
- Complexity     2151     2155       +4     
============================================
  Files          3669     3672       +3     
  Lines         54139    54129      -10     
  Branches       9186     9186              
============================================
+ Hits          31919    31942      +23     
+ Misses        19515    19481      -34     
- Partials       2705     2706       +1     
Impacted Files Coverage Δ
...e/shardingsphere/infra/instance/utils/IpUtils.java 60.00% <0.00%> (-8.00%) ⬇️
...l/parser/core/database/visitor/SQLVisitorRule.java 100.00% <0.00%> (ø)
...gy/sharding/NoneShardingStrategyConfiguration.java 0.00% <0.00%> (ø)
...ngsphere/infra/instance/definition/InstanceId.java
...common/statement/ddl/CreateDiskgroupStatement.java 0.00% <0.00%> (ø)
...i/sharding/standard/StandardShardingAlgorithm.java 0.00% <0.00%> (ø)
...tatement/ddl/CreateDiskgroupStatementTestCase.java 100.00% <0.00%> (ø)
...ent/oracle/ddl/OracleCreateDiskgroupStatement.java 0.00% <0.00%> (ø)
...eterized/jaxb/cases/domain/SQLParserTestCases.java 99.85% <0.00%> (+<0.01%) ⬆️
...r/statement/impl/OracleDDLStatementSQLVisitor.java 87.50% <0.00%> (+0.04%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4332e31...06f9381. Read the comment docs.

@zhaojinchao95
Copy link
Contributor

@misselvexu Why not submit multiple PRs separately? it's too painful for reviewers.

@misselvexu
Copy link
Contributor Author

@misselvexu Why not submit multiple PRs separately? it's too painful for reviewers.

Too much pr is a bit troublesome.

@terrymanu terrymanu merged commit 77a88a7 into apache:master Jun 6, 2022
@terrymanu terrymanu added this to the 5.1.2 milestone Jun 6, 2022
@zhaojinchao95 zhaojinchao95 mentioned this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment