Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread ALTER SEQUENCE grammar + add test cases #19291

Merged
merged 1 commit into from Jul 18, 2022

Conversation

everly-gif
Copy link
Contributor

@everly-gif everly-gif commented Jul 17, 2022

Ref #17848 .
Sub-issue of #14015

Changes proposed in this pull request:

  • Proofread ALTER SEQUENCEgrammar
  • Add Tests

@codecov-commenter
Copy link

Codecov Report

Merging #19291 (8477d5d) into master (04cbfa2) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #19291      +/-   ##
============================================
- Coverage     59.50%   59.50%   -0.01%     
  Complexity     2371     2371              
============================================
  Files          3817     3817              
  Lines         54327    54327              
  Branches       9244     9244              
============================================
- Hits          32329    32326       -3     
- Misses        19242    19245       +3     
  Partials       2756     2756              
Impacted Files Coverage Δ
...nd/text/distsql/ral/hint/enums/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cbfa2...8477d5d. Read the comment docs.

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@everly-gif Looks great, merged.

@strongduanmu strongduanmu merged commit 888b43a into apache:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants