Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Snakeyaml to 1.33 and open YAML 3MB limit #21351

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Oct 5, 2022

Fixes #21048.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have passed maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian changed the title Update Snakeyaml to 1.33 to open 3MB limit Update Snakeyaml to 1.33 to open YAML 3MB limit Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #21351 (d8b9fc5) into master (163a4bd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #21351   +/-   ##
=========================================
  Coverage     61.56%   61.57%           
  Complexity     2507     2507           
=========================================
  Files          4089     4089           
  Lines         56614    56616    +2     
  Branches       7489     7489           
=========================================
+ Hits          34857    34859    +2     
  Misses        18838    18838           
  Partials       2919     2919           
Impacted Files Coverage Δ
...che/shardingsphere/infra/util/yaml/YamlEngine.java 88.23% <100.00%> (ø)
...aml/constructor/ShardingSphereYamlConstructor.java 90.90% <100.00%> (+2.02%) ⬆️
...aml/representer/ShardingSphereYamlRepresenter.java 88.88% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghengqian linghengqian marked this pull request as ready for review October 5, 2022 16:23
@linghengqian linghengqian changed the title Update Snakeyaml to 1.33 to open YAML 3MB limit Update Snakeyaml to 1.33 and open YAML 3MB limit Oct 5, 2022
@strongduanmu strongduanmu added this to the 5.2.1 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants