Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename constant package to enums and rename NullsOrderDirection to NullsOrderType #22256

Merged
merged 1 commit into from Nov 18, 2022
Merged

Rename constant package to enums and rename NullsOrderDirection to NullsOrderType #22256

merged 1 commit into from Nov 18, 2022

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Nov 18, 2022 •
edited

Ref #22170.

Changes proposed in this pull request:

  • Rename constant package to enums
  • rename NullsOrderDirection to NullsOrderType

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu strongduanmu added this to the 5.2.2 milestone Nov 18, 2022
@tuichenchuxin tuichenchuxin merged commit 1aab710 into apache:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuichenchuxin tuichenchuxin tuichenchuxin approved these changes

Assignees
No one assigned
Labels
in: kernel type: refactor
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strongduanmu @tuichenchuxin