Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2319 bug fixes #2338

Closed
wants to merge 2 commits into from
Closed

Conversation

codefairy08
Copy link
Contributor

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

@terrymanu
Copy link
Member

ColumnSegment need to reference TableSegment, do not add a new filed name as originalName

@coveralls
Copy link

coveralls commented May 7, 2019

Pull Request Test Coverage Report for Build 7945

  • 2 of 11 (18.18%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 55.047%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/segment/dml/column/ColumnSegment.java 0 2 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/statement/dml/InsertStatement.java 1 4 25.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/dml/InsertColumnsFiller.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/segment/dml/column/ColumnSegment.java 1 0.0%
Totals Coverage Status
Change from base Build 7943: -0.03%
Covered Lines: 8671
Relevant Lines: 15752

💛 - Coveralls

@terrymanu
Copy link
Member

It is rewrite problem, we should not change parse module.
We should split insert column and insert values as 2 token .

@terrymanu terrymanu closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants